You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/08 14:23:30 UTC
[GitHub] [beam] mosche opened a new pull request, #24032: [Metrics] Add new performance dashboard for Java JMH benchmarks
mosche opened a new pull request, #24032:
URL: https://github.com/apache/beam/pull/24032
Add new performance dashboard for Java JMH benchmarks (closes #22238).
The lack of Flux support (#23691) made it a bit harder to create decent charts. Also, these will be wrong when new benchmark parameters are added without adjusting the respective group by clause.
<img width="1724" alt="Screenshot 2022-11-08 at 14 54 26" src="https://user-images.githubusercontent.com/1401430/200589341-d786f037-b9b4-4a59-9d2c-e4be74d1e2c4.png">
<img width="1722" alt="Screenshot 2022-11-08 at 14 54 46" src="https://user-images.githubusercontent.com/1401430/200589368-1e5350a2-6b00-4670-9e55-f820b12c78f7.png">
<img width="1722" alt="Screenshot 2022-11-08 at 14 55 16" src="https://user-images.githubusercontent.com/1401430/200589420-a3beb40b-6c0f-4c80-8397-2d8e81944756.png">
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on pull request #24032: [Metrics] Add new performance dashboard for Java JMH benchmarks
Posted by GitBox <gi...@apache.org>.
mosche commented on PR #24032:
URL: https://github.com/apache/beam/pull/24032#issuecomment-1307302539
R: @aromanenko-dev
R: @lukecwik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev merged pull request #24032: [Metrics] Add new performance dashboard for Java JMH benchmarks
Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged PR #24032:
URL: https://github.com/apache/beam/pull/24032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on pull request #24032: [Metrics] Add new performance dashboard for Java JMH benchmarks
Posted by GitBox <gi...@apache.org>.
mosche commented on PR #24032:
URL: https://github.com/apache/beam/pull/24032#issuecomment-1318674725
@aromanenko-dev could you have a look, pls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #24032: [Metrics] Add new performance dashboard for Java JMH benchmarks
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #24032:
URL: https://github.com/apache/beam/pull/24032#issuecomment-1319347425
Thanks for getting this done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24032: [Metrics] Add new performance dashboard for Java JMH benchmarks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24032:
URL: https://github.com/apache/beam/pull/24032#issuecomment-1307304170
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org