You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/06/01 15:35:38 UTC
[GitHub] [maven] gnodet opened a new pull request #475: [MNG-7157] [MNG-6843] Provide a better design for obtaining artifacts…
gnodet opened a new pull request #475:
URL: https://github.com/apache/maven/pull/475
… from a MavenProject inside a mojo
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] famod commented on pull request #475: [MNG-7157] [MNG-6843] Provide a better design for obtaining artifacts…
Posted by GitBox <gi...@apache.org>.
famod commented on pull request #475:
URL: https://github.com/apache/maven/pull/475#issuecomment-855066486
Is this really a follow-up? Instead, to me it seems like an alternative, more comprehensive solution than #413?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #475: [MNG-7157] [MNG-6843] Provide a better design for obtaining artifacts…
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #475:
URL: https://github.com/apache/maven/pull/475#issuecomment-855454398
> Is this really a follow-up? Instead, to me it seems like an alternative, more comprehensive solution than #413?
Yes, the wording is wrong. I originally went to only extend and provide an alternative api, but then refactored your original proposal a bit, so it's now more an extended alternative....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] famod commented on a change in pull request #475: [MNG-7157] [MNG-6843] Provide a better design for obtaining artifacts…
Posted by GitBox <gi...@apache.org>.
famod commented on a change in pull request #475:
URL: https://github.com/apache/maven/pull/475#discussion_r645891893
##########
File path: maven-core/src/main/java/org/apache/maven/project/MavenProject.java
##########
@@ -347,84 +351,62 @@ public void addTestCompileSourceRoot( String path )
return testCompileSourceRoots;
}
+ @Deprecated
Review comment:
It would be nice to document what to use instead (and why) via JavaDoc `@deprecated ...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on a change in pull request #475: [MNG-7157] [MNG-6843] Provide a better design for obtaining artifacts…
Posted by GitBox <gi...@apache.org>.
gnodet commented on a change in pull request #475:
URL: https://github.com/apache/maven/pull/475#discussion_r646180776
##########
File path: maven-core/src/main/java/org/apache/maven/project/MavenProject.java
##########
@@ -347,84 +351,62 @@ public void addTestCompileSourceRoot( String path )
return testCompileSourceRoots;
}
+ @Deprecated
Review comment:
I'm willing to provide more doc once there's a consensus.
Honestly, I'm not even sure we need such an API, unless there's a clear path for the deprecation and for moving to a more immutable `MavenProject`. What are the deprecation rules ? Will 4.0 remove things deprecated in 3.x ? If they stay forever, there's really no point in deprecating and trying to find slightly better APIs... I'm just asking here, but 3.0 is very old I think there are quite a few things that are deprecated since early 3.x versions, which looks like 10 years or so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #475: [MNG-7157] [MNG-6843] Provide a better design for obtaining artifacts…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #475:
URL: https://github.com/apache/maven/pull/475#discussion_r659294940
##########
File path: maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java
##########
@@ -244,6 +246,10 @@ else if ( "mojoExecution".equals( expression ) )
{
value = mojoExecution;
}
+ else if ( "artifactFilter".equals( expression ) )
Review comment:
We should investigate if we can solve this with MPLUGIN-302 instead of exposing this a new expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org