You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/14 10:39:01 UTC

[GitHub] [flink] gaoyunhaii opened a new pull request #16827: [FLINK-23771][runtime][checkpoint] Fix the issue of getAllReceivedFuture if all channels are finished

gaoyunhaii opened a new pull request #16827:
URL: https://github.com/apache/flink/pull/16827


   ## What is the purpose of the change
   
   This pr fixes the failed state check when call `CheckpointBarrierHandler#getAllReceivedFuture()` when trigger unaligned checkpoint to a non-source task whose inputs are all finished.
   
   ## Brief change log
   
   - 3138463a7c663261380dc6bcd19376474ee03902 fixes the issue by judging if all channels are finished, if so, returns a completed future directly.
   
   ## Verifying this change
   
   This change is verified with the added ut.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive):**no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **yes**
     - The S3 file system connector: **no**
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16827: [FLINK-23771][runtime][checkpoint] Fix the issue of getAllReceivedFuture if all channels are finished

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16827:
URL: https://github.com/apache/flink/pull/16827#issuecomment-898877727


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 3138463a7c663261380dc6bcd19376474ee03902 (Sat Aug 14 10:41:35 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-23771).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaoyunhaii edited a comment on pull request #16827: [FLINK-23771][runtime][checkpoint] Fix the issue of getAllReceivedFuture if all channels are finished

Posted by GitBox <gi...@apache.org>.
gaoyunhaii edited a comment on pull request #16827:
URL: https://github.com/apache/flink/pull/16827#issuecomment-899263993


   Very thanks Piotr @pnowojski for the review! Merging~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaoyunhaii closed pull request #16827: [FLINK-23771][runtime][checkpoint] Fix the issue of getAllReceivedFuture if all channels are finished

Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #16827:
URL: https://github.com/apache/flink/pull/16827


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16827: [FLINK-23771][runtime][checkpoint] Fix the issue of getAllReceivedFuture if all channels are finished

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16827:
URL: https://github.com/apache/flink/pull/16827#issuecomment-898881604


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8a52b64fa89231fc97b4cd625eb3359a0988cc8b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22184",
       "triggerID" : "8a52b64fa89231fc97b4cd625eb3359a0988cc8b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8a52b64fa89231fc97b4cd625eb3359a0988cc8b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22184) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16827: [FLINK-23771][runtime][checkpoint] Fix the issue of getAllReceivedFuture if all channels are finished

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16827:
URL: https://github.com/apache/flink/pull/16827#issuecomment-898881604


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8a52b64fa89231fc97b4cd625eb3359a0988cc8b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8a52b64fa89231fc97b4cd625eb3359a0988cc8b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8a52b64fa89231fc97b4cd625eb3359a0988cc8b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16827: [FLINK-23771][runtime][checkpoint] Fix the issue of getAllReceivedFuture if all channels are finished

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16827:
URL: https://github.com/apache/flink/pull/16827#issuecomment-898881604


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8a52b64fa89231fc97b4cd625eb3359a0988cc8b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22184",
       "triggerID" : "8a52b64fa89231fc97b4cd625eb3359a0988cc8b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8a52b64fa89231fc97b4cd625eb3359a0988cc8b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22184) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaoyunhaii commented on pull request #16827: [FLINK-23771][runtime][checkpoint] Fix the issue of getAllReceivedFuture if all channels are finished

Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #16827:
URL: https://github.com/apache/flink/pull/16827#issuecomment-899263993


   Very thanks Piotr @pnowojski for the review! Merging...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org