You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/12/29 11:16:56 UTC

[GitHub] [kylin] zhengshengjun commented on a change in pull request #1523: fix KYLIN-4850, merge Cube's override kylin_properties into building …

zhengshengjun commented on a change in pull request #1523:
URL: https://github.com/apache/kylin/pull/1523#discussion_r549667034



##########
File path: kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java
##########
@@ -105,7 +105,7 @@ protected ExecuteResult doWork(ExecutableContext context) throws ExecuteExceptio
         //context.setLogPath(getSparkDriverLogHdfsPath(context.getConfig()));
         CubeManager cubeMgr = CubeManager.getInstance(KylinConfig.getInstanceFromEnv());
         CubeInstance cube = cubeMgr.getCube(this.getCubeName());
-        KylinConfig config = cube.getConfig();
+        KylinConfig config = KylinConfigExt.createInstance(cube.getConfig(), cube.getDescriptor().getOverrideKylinProps());

Review comment:
        thansks you for your advice ~




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org