You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "onebox-li (via GitHub)" <gi...@apache.org> on 2023/10/27 03:26:43 UTC
[PR] [CELEBORN-1093] Improve setup endpoint [incubator-celeborn]
onebox-li opened a new pull request, #2049:
URL: https://github.com/apache/incubator-celeborn/pull/2049
### What changes were proposed in this pull request?
Avoid transform RpcEndpointAddress -> celebornUrl -> RpcEndpointAddress when setupEndpointRef.
### Why are the changes needed?
Ditto
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Cluster test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1093] Improve setup endpoint [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2049:
URL: https://github.com/apache/incubator-celeborn/pull/2049#issuecomment-1782241198
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2049?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2049](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2049?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (643c192) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/5d3ae318bf292a3b812032e93101e3529d1cd7fc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5d3ae31) will **increase** coverage by `0.18%`.
> Report is 1 commits behind head on main.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #2049 +/- ##
==========================================
+ Coverage 46.65% 46.82% +0.18%
==========================================
Files 165 165
Lines 10525 10523 -2
Branches 957 957
==========================================
+ Hits 4909 4926 +17
+ Misses 5294 5278 -16
+ Partials 322 319 -3
```
| [Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2049?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../scala/org/apache/celeborn/common/rpc/RpcEnv.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2049?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3JwYy9ScGNFbnYuc2NhbGE=) | `61.91% <0.00%> (ø)` | |
| [...apache/celeborn/common/rpc/netty/NettyRpcEnv.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2049?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3JwYy9uZXR0eS9OZXR0eVJwY0Vudi5zY2FsYQ==) | `17.21% <0.00%> (+0.13%)` | :arrow_up: |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2049/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1093] Improve setup endpoint [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #2049: [CELEBORN-1093] Improve setup endpoint
URL: https://github.com/apache/incubator-celeborn/pull/2049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org