[GitHub] [incubator-uniffle] duanmeng commented on a diff in pull request #43: Explicitly set the constructor with AccessManager when extending Acce…

[GitBox <gi...@apache.org>]

duanmeng commented on code in PR #43:
URL: https://github.com/apache/incubator-uniffle/pull/43#discussion_r918838492


##########
coordinator/src/main/java/org/apache/uniffle/coordinator/AccessChecker.java:
##########
@@ -20,15 +20,20 @@
 import java.io.Closeable;
 
 /**
- *  Interface for checking the access info from the client-side.
+ *  Abstract class for checking the access info from the client-side.
  */
-public interface AccessChecker extends Closeable {
+public abstract class AccessChecker implements Closeable {
+  protected AccessManager accessManager;

Review Comment:
   Why do we need a member `AccessManager` since we only need to use it to extract confs in the checker's constructor?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org