You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/24 11:52:17 UTC

[GitHub] [airflow] bhirsz commented on a diff in pull request #25934: Fix gcs to sftp system test

bhirsz commented on code in PR #25934:
URL: https://github.com/apache/airflow/pull/25934#discussion_r953697936


##########
tests/system/providers/google/cloud/transfers/example_gcs_to_sftp.py:
##########
@@ -46,12 +53,35 @@
     catchup=False,
     tags=['example', 'gcs'],
 ) as dag:
+    create_bucket = GCSCreateBucketOperator(
+        task_id="create_bucket", bucket_name=BUCKET_NAME, project_id=PROJECT_ID
+    )
+
+    upload_file_1 = LocalFilesystemToGCSOperator(

Review Comment:
   To ensure I have file available on different paths - directly in bucket root, under directory etc. It's łatwe used by transfer operator and we are testing if its possible to copy file, copy file from dir (and recreate dir structures), copy with wildcard. But thanks to your question I have noticed we dont need third upload - since 2nd upload already puts file under dir and we came reuse it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org