You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/30 23:55:17 UTC

[GitHub] [spark] reidy-p opened a new pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

reidy-p opened a new pull request #29918:
URL: https://github.com/apache/spark/pull/29918


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   Adding a method to get the checkpoint directory from the PySpark context to match the Scala API
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   To make the Scala and Python APIs consistent and remove the need to use the JavaObject
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   Yes, there is a new method which makes it easier to get the checkpoint directory directly rather than using the JavaObject
   
   #### Previous behaviour:
   ```python
   >>> spark.sparkContext.setCheckpointDir('/tmp/spark/checkpoint/')
   >>> sc._jsc.sc().getCheckpointDir().get()
   'file:/tmp/spark/checkpoint/63f7b67c-e5dc-4d11-a70c-33554a71717a'
   ```
   This method returns a confusing Scala error if it has not been set
   ```python
   >>> sc._jsc.sc().getCheckpointDir().get()
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
     File "/home/paul/Desktop/spark/python/lib/py4j-0.10.9-src.zip/py4j/java_gateway.py", line 1305, in __call__
     File "/home/paul/Desktop/spark/python/pyspark/sql/utils.py", line 111, in deco
       return f(*a, **kw)
     File "/home/paul/Desktop/spark/python/lib/py4j-0.10.9-src.zip/py4j/protocol.py", line 328, in get_return_value
   py4j.protocol.Py4JJavaError: An error occurred while calling o25.get.
   : java.util.NoSuchElementException: None.get
           at scala.None$.get(Option.scala:529)
           at scala.None$.get(Option.scala:527)
           at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
           at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
           at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
           at java.lang.reflect.Method.invoke(Method.java:498)
           at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
           at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:357)
           at py4j.Gateway.invoke(Gateway.java:282)
           at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
           at py4j.commands.CallCommand.execute(CallCommand.java:79)
           at py4j.GatewayConnection.run(GatewayConnection.java:238)
           at java.lang.Thread.run(Thread.java:748)
   
   ```
   
   #### New method:
   ```python
   >>> spark.sparkContext.setCheckpointDir('/tmp/spark/checkpoint/')
   >>> spark.sparkContext.getCheckpointDir()
   'file:/tmp/spark/checkpoint/b38aca2e-8ace-44fc-a4c4-f4e36c2da2a7'
   ```
   
   ``getCheckpointDir()`` returns ``None`` if it has not been set
   ```python
   >>> print(spark.sparkContext.getCheckpointDir())
   None
   ```
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Added to existing unit tests. But I'm not sure how to add a test for the case where ``getCheckpointDir()`` should return ``None`` since the existing checkpoint tests set the checkpoint directory in the ``setUp`` method before any tests are run as far as I can tell.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-703308473


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33999/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-703306294






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-703303125


   **[Test build #129392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129392/testReport)** for PR 29918 at commit [`7ff4e88`](https://github.com/apache/spark/commit/7ff4e88627505e092281ec50f6237b3ae994638d).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-701706604


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-703306195


   **[Test build #129392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129392/testReport)** for PR 29918 at commit [`7ff4e88`](https://github.com/apache/spark/commit/7ff4e88627505e092281ec50f6237b3ae994638d).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-703311583






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29918:
URL: https://github.com/apache/spark/pull/29918


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-702547950






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] reidy-p commented on a change in pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
reidy-p commented on a change in pull request #29918:
URL: https://github.com/apache/spark/pull/29918#discussion_r498966470



##########
File path: python/pyspark/context.py
##########
@@ -956,6 +956,15 @@ def setCheckpointDir(self, dirName):
         """
         self._jsc.sc().setCheckpointDir(dirName)
 
+    def getCheckpointDir(self):

Review comment:
       Thanks for the review. Do you know how to properly import ``since`` into ``python/pyspark/context.py``? ``since`` is defined in the ``python/pyspark/__init__.py`` and I haven't been able to import it into ``python/pyspark/context.py`` without getting errors.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-701706950


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29918:
URL: https://github.com/apache/spark/pull/29918#discussion_r498615956



##########
File path: python/pyspark/context.py
##########
@@ -956,6 +956,15 @@ def setCheckpointDir(self, dirName):
         """
         self._jsc.sc().setCheckpointDir(dirName)
 
+    def getCheckpointDir(self):

Review comment:
       Should also add the corresponding type hint below https://github.com/apache/spark/blob/master/python/pyspark/context.pyi#L154 line. cc @zero323 FYI.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-703306294






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-701706950


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29918:
URL: https://github.com/apache/spark/pull/29918#discussion_r498615825



##########
File path: python/pyspark/context.py
##########
@@ -956,6 +956,15 @@ def setCheckpointDir(self, dirName):
         """
         self._jsc.sc().setCheckpointDir(dirName)
 
+    def getCheckpointDir(self):

Review comment:
       Let's also decorate this with `@since(3.1)`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-702558568






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-703311583






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on a change in pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #29918:
URL: https://github.com/apache/spark/pull/29918#discussion_r498987884



##########
File path: python/pyspark/context.py
##########
@@ -956,6 +956,15 @@ def setCheckpointDir(self, dirName):
         """
         self._jsc.sc().setCheckpointDir(dirName)
 
+    def getCheckpointDir(self):

Review comment:
       That's because of circular dependency, right?
   
   I think the only way to make it work is to move 
   
   https://github.com/apache/spark/blob/82721ce00b6cf535abd3d9cd66445e452554d15d/python/pyspark/__init__.py#L53
   
   somewhere after `since` definition, for example here:
   
   https://github.com/apache/spark/blob/82721ce00b6cf535abd3d9cd66445e452554d15d/python/pyspark/__init__.py#L116-L117
   
   I am not sure if we want to go this way though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-702535179


   **[Test build #129335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129335/testReport)** for PR 29918 at commit [`3f05f9c`](https://github.com/apache/spark/commit/3f05f9c7fffec7548213a18d25ff56d8fed08787).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-702521513


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-702547950






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-702535179


   **[Test build #129335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129335/testReport)** for PR 29918 at commit [`3f05f9c`](https://github.com/apache/spark/commit/3f05f9c7fffec7548213a18d25ff56d8fed08787).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-703367936


   Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-702549665


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33948/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-702558352


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33948/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-701706604


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-703303125


   **[Test build #129392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129392/testReport)** for PR 29918 at commit [`7ff4e88`](https://github.com/apache/spark/commit/7ff4e88627505e092281ec50f6237b3ae994638d).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-702558568






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-703311574


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33999/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on a change in pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #29918:
URL: https://github.com/apache/spark/pull/29918#discussion_r498649091



##########
File path: python/pyspark/context.py
##########
@@ -956,6 +956,15 @@ def setCheckpointDir(self, dirName):
         """
         self._jsc.sc().setCheckpointDir(dirName)
 
+    def getCheckpointDir(self):

Review comment:
       Just for the reference ‒ it will be just
   
   ```python
       def getCheckpointDir(self) -> Optional[str]: ...
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29918: [SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29918:
URL: https://github.com/apache/spark/pull/29918#issuecomment-702545701


   **[Test build #129335 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129335/testReport)** for PR 29918 at commit [`3f05f9c`](https://github.com/apache/spark/commit/3f05f9c7fffec7548213a18d25ff56d8fed08787).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org