You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/23 17:16:47 UTC
[GitHub] [airflow] KevYuen opened a new pull request #13289: pass image_pull_policy to V1Container
KevYuen opened a new pull request #13289:
URL: https://github.com/apache/airflow/pull/13289
image_pull_policy is not being passed into the V1Container in `KubernetesPodOperator`
This causes pods to not re-pull images even if the value is set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #13289: Pass image_pull_policy in KubernetesPodOperator correctly
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #13289:
URL: https://github.com/apache/airflow/pull/13289#issuecomment-750928854
No problem ;-) Happy holidays ahead btw!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] KevYuen commented on pull request #13289: Pass image_pull_policy in KubernetesPodOperator correctly
Posted by GitBox <gi...@apache.org>.
KevYuen commented on pull request #13289:
URL: https://github.com/apache/airflow/pull/13289#issuecomment-750928604
Thanks @XD-DENG! Much appreciated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13289: image_pull_policy in KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13289:
URL: https://github.com/apache/airflow/pull/13289#issuecomment-750922067
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13289: image_pull_policy in KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13289:
URL: https://github.com/apache/airflow/pull/13289#issuecomment-750410513
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #13289: image_pull_policy in KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #13289:
URL: https://github.com/apache/airflow/pull/13289#discussion_r548154069
##########
File path: tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py
##########
@@ -99,6 +99,33 @@ def test_image_pull_secrets_correctly_set(self, mock_client, monitor_mock, start
[k8s.V1LocalObjectReference(name=fake_pull_secrets)],
)
+ @mock.patch("airflow.kubernetes.pod_launcher.PodLauncher.start_pod")
+ @mock.patch("airflow.kubernetes.pod_launcher.PodLauncher.monitor_pod")
+ @mock.patch("airflow.kubernetes.kube_client.get_kube_client")
+ def test_image_pull_policy_correctly_set(self, mock_client, monitor_mock, start_mock):
Review comment:
Shall we have one more test case, where we don't explicitly specify `image_pull_policy` then assert it against default value `IfNotPresent `?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #13289: Pass image_pull_policy in KubernetesPodOperator correctly
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #13289:
URL: https://github.com/apache/airflow/pull/13289
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org