You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by bo...@apache.org on 2019/09/01 14:10:13 UTC

[commons-compress] 01/04: COMPRESS-491 overlooked the code was already checking for 0 len

This is an automated email from the ASF dual-hosted git repository.

bodewig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git

commit 2488a44faec06a91ae52652407fb0a881ed217d2
Author: Stefan Bodewig <bo...@apache.org>
AuthorDate: Sat Aug 31 15:15:44 2019 +0200

    COMPRESS-491 overlooked the code was already checking for 0 len
---
 .../apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java | 3 ---
 .../commons/compress/compressors/bzip2/BZip2CompressorInputStream.java | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java b/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java
index e9406eb..da20cf8 100644
--- a/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java
+++ b/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java
@@ -303,9 +303,6 @@ public class CpioArchiveInputStream extends ArchiveInputStream implements
     @Override
     public int read(final byte[] b, final int off, final int len)
             throws IOException {
-        if (len == 0) {
-            return 0;
-        }
         ensureOpen();
         if (off < 0 || len < 0 || off > b.length - len) {
             throw new IndexOutOfBoundsException();
diff --git a/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java b/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java
index cd82a99..1a5e2ab 100644
--- a/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java
+++ b/src/main/java/org/apache/commons/compress/compressors/bzip2/BZip2CompressorInputStream.java
@@ -154,9 +154,6 @@ public class BZip2CompressorInputStream extends CompressorInputStream
     @Override
     public int read(final byte[] dest, final int offs, final int len)
         throws IOException {
-        if (len == 0) {
-            return 0;
-        }
         if (offs < 0) {
             throw new IndexOutOfBoundsException("offs(" + offs + ") < 0.");
         }