[jira] [Commented] (YARN-8805) Automatically convert the launch command to the exec form when using entrypoint support

["Eric Badger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781864#comment-16781864 ] 

Eric Badger commented on YARN-8805:
-----------------------------------

[~eyang], is there a reason we need to handle the case where there are leading or trailing quotes (")? If they are put into the launch command then they aren't going to be evaluated, right? So they would be literals and we would just want to treat them as any other character. If we can make that assumption then all we need to do is a {{trim()}} and then a {{replaceAll}} for whitespace with commas

> Automatically convert the launch command to the exec form when using entrypoint support
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-8805
>                 URL: https://issues.apache.org/jira/browse/YARN-8805
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Shane Kumpf
>            Assignee: Eric Yang
>            Priority: Major
>              Labels: Docker
>         Attachments: YARN-8805.001.patch, YARN-8805.004.patch, YARN-8805.005.patch
>
>
> When {{YARN_CONTAINER_RUNTIME_DOCKER_RUN_OVERRIDE_DISABLE}} is true, and a launch command is provided, it is expected that the launch command is provided by the user in exec form.
> For example:
> {code:java}
> "/usr/bin/sleep 6000"{code}
> must be changed to:
> {code}"/usr/bin/sleep,6000"{code}
> If this is not done, the container will never start and will be in a Created state. We should automatically do this conversion vs making the user understand this nuance of using the entrypoint support. Docs should be updated to reflect this change.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org