[GitHub] [airflow] Jorricks commented on pull request #17207: Fix external_executor_id not being set for manually run jobs.

[GitBox <gi...@apache.org>]

Jorricks commented on pull request #17207:
URL: https://github.com/apache/airflow/pull/17207#issuecomment-914236678


   > > I tried to add some tests on the CLI task part. That is pretty much done.
   > > However, I had quite some trouble wrapping my head around a decent test approach on the celery_executor part.
   > > There is currently not really a test for any of the functions I modified which makes me wonder if I should add them.
   > > If so, do you have any remarks on how I could best do that?
   > 
   > For the methods modified in CeleryExecutor, you can mock them and assert they were called with a celeryID.
   > The app can be mocked to return an ID. See
   > 
   > https://github.com/apache/airflow/blob/3d96ad62f91e662b62481441d8eec2994651e122/tests/executors/test_celery_executor.py#L75
   > 
   > 
   > You can provide appID there.
   
   I modified the existing test to add this behaviour.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org