You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by as...@apache.org on 2025/02/25 09:00:19 UTC

(apisix) branch master updated: fix: error while trying to log table in ai-content-moderation plugin (#11994)

This is an automated email from the ASF dual-hosted git repository.

ashishtiwari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
     new adaa080b2 fix: error while trying to log table in ai-content-moderation plugin (#11994)
adaa080b2 is described below

commit adaa080b2734ce314b3b7a26fb33e4d2bafe1563
Author: Ashish Tiwari <as...@gmail.com>
AuthorDate: Tue Feb 25 14:30:14 2025 +0530

    fix: error while trying to log table in ai-content-moderation plugin (#11994)
---
 apisix/plugins/ai-content-moderation.lua |  2 +-
 t/plugin/ai-content-moderation2.t        | 88 ++++++++++++++++++++++++++++++++
 2 files changed, 89 insertions(+), 1 deletion(-)

diff --git a/apisix/plugins/ai-content-moderation.lua b/apisix/plugins/ai-content-moderation.lua
index 19029a653..f4958f321 100644
--- a/apisix/plugins/ai-content-moderation.lua
+++ b/apisix/plugins/ai-content-moderation.lua
@@ -148,7 +148,7 @@ function _M.rewrite(conf, ctx)
     })
 
     if not res then
-        core.log.error("failed to send request to ", provider, ": ", err)
+        core.log.error("failed to send request to ", endpoint, ": ", err)
         return HTTP_INTERNAL_SERVER_ERROR, err
     end
 
diff --git a/t/plugin/ai-content-moderation2.t b/t/plugin/ai-content-moderation2.t
new file mode 100644
index 000000000..f509b1864
--- /dev/null
+++ b/t/plugin/ai-content-moderation2.t
@@ -0,0 +1,88 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+use t::APISIX 'no_plan';
+
+log_level("info");
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+
+add_block_preprocessor(sub {
+    my ($block) = @_;
+
+    if (!defined $block->request) {
+        $block->set_value("request", "GET /t");
+    }
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: sanity
+--- config
+    location /t {
+        content_by_lua_block {
+            local t = require("lib.test_admin").test
+            local code, body = t('/apisix/admin/routes/1',
+                ngx.HTTP_PUT,
+                [[{
+                    "uri": "/echo",
+                    "plugins": {
+                        "ai-content-moderation": {
+                            "provider": {
+                                "aws_comprehend": {
+                                    "access_key_id": "access",
+                                    "secret_access_key": "ea+secret",
+                                    "region": "us-east-1",
+                                    "endpoint": "http://localhost:2668"
+                                }
+                            },
+                            "llm_provider": "openai"
+                        }
+                    },
+                    "upstream": {
+                        "type": "roundrobin",
+                        "nodes": {
+                            "127.0.0.1:1980": 1
+                        }
+                    }
+                }]]
+            )
+
+            if code >= 300 then
+                ngx.status = code
+            end
+            ngx.say(body)
+        }
+    }
+--- response_body
+passed
+
+
+
+=== TEST 2: request should fail
+--- request
+POST /echo
+{"model":"gpt-4o-mini","messages":[{"role":"user","content":"toxic"}]}
+--- error_code: 500
+--- response_body chomp
+Comprehend:detectToxicContent() failed to connect to 'http://localhost:2668': connection refused
+--- error_log
+failed to send request to http://localhost: Comprehend:detectToxicContent() failed to connect to 'http://localhost:2668': connection refused