You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/07/02 07:18:17 UTC

[GitHub] [hudi] vaibhav-sinha commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

vaibhav-sinha commented on pull request #2923:
URL: https://github.com/apache/hudi/pull/2923#issuecomment-872778115


   @n3nash Essentially we did two things in this PR. We changed the representation of `timestamp` based LogicalType and added the support for Data/Timestamp based objects in `TmestampBasedAvroKeyGenerator`. Both of these are independent of each other.
   
   Hence, we can continue using `long` to represent `timestamp` if the memory footprint is a concern. In that case, I would suggest we should represent `Date` as `integer` just to be consistent with representations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org