[GitHub] [incubator-mxnet] bgawrych commented on a change in pull request #20268: [operator] Add logsigmoid activation function

[GitBox <gi...@apache.org>]

bgawrych commented on a change in pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#discussion_r636722450



##########
File path: src/operator/nn/mkldnn/mkldnn_act.cc
##########
@@ -83,6 +84,8 @@ mkldnn::algorithm GetMKLDNNActAlgo(const ActivationParam& param) {
       return mkldnn::algorithm::eltwise_relu;
     case activation::kSigmoid:
       return mkldnn::algorithm::eltwise_logistic;
+    case activation::kLogSigmoid:

Review comment:
       This function is used with oneDNN subgraphs also, can you add tests in test_fc_subgraph.py and test_conv_subgraph.py

##########
File path: src/operator/tensor/elemwise_unary_op_basic.cc
##########
@@ -196,6 +196,23 @@ MXNET_OPERATOR_REGISTER_BINARY(_backward_softsign)
 .set_attr<FCompute>("FCompute<cpu>", ElemwiseBinaryOp::Compute<cpu,
   unary_bwd<mshadow_op::softsign_grad> >);
 
+// log_sigmoid

Review comment:
       Maybe move this fragment of code below sigmoid registration?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org