[GitHub] [metron] tigerquoll opened a new pull request #1383: METRON-1788 Batch profiler pull profile information from zookeeper

[GitBox <gi...@apache.org>]

tigerquoll opened a new pull request #1383: METRON-1788 Batch profiler pull profile information from zookeeper
URL: https://github.com/apache/metron/pull/1383
 
 
   ## Contributor Comments
   An enhancement to the batch profiler to allow for pulling profile information from zookeeper.  Also added a 'timestampfield' option so the event time source field can be specified on the command line (using the processing time is not helpful for batch processing modes).  If existing command line and/or environment variables remain unchanged then the batch profiler will continue to read profile definitions from the file system.  
   
   ## Changes
   * zookeeper and timestampfield command line options were added to the batch profiler (The batch profiler utilises the same Metron API to pull profile definitions from zookeeper as Stellar does).
   * The wrapper script for batch profiler was updated to support the new options. To support this the wrapper script now passes command line options to the underlying program.
   * The Readme file were updated to document the new options.
   
   ## Testing
   Unit tests added for additional parameter handling.  A Metron dev cluster was manually spun up to test reading of profile information.  As the batch profiler now utilises the same API as Stellar does to read profile information,  it also leverages the same testing that is setup around the Stellar engine.  Documentation markdown rendering was checked utilising the Intellij Markdown module, as I was unable to get site-book building running on MacOS.
   Travis CI testing run completed successfully on private repo.
   
   ## Pull Request Checklist
   
   Thank you for submitting a contribution to Apache Metron.  
   Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
   Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
   
   
   In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
   - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   
   ### For code changes:
   - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
   - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
   - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
     ```
     mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
     ```
   
   - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
   
     ```
     cd site-book
     mvn site
     ```
   
   #### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services