You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/08 17:03:30 UTC

[GitHub] [kafka] junrao commented on pull request #9393: KAFKA-10028: Minor fixes to describeFeatures and updateFeatures apis

junrao commented on pull request #9393:
URL: https://github.com/apache/kafka/pull/9393#issuecomment-705702092


   In this PR, I have addressed the review comments from @chia7712 in #9001 which were provided after #9001 was merged. The changes are made mainly to KafkaAdminClient:
   
   Improve error message in updateFeatures api when feature name is empty.
   Propagate top-level error message in updateFeatures api.
   Add an empty-parameter variety for describeFeatures api.
   Minor documentation updates to @param and @return to make these resemble other apis.
   
   Reviewers: Chia-Ping Tsai <ch...@gmail.com>, Jun Rao <ju...@gmail.com>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org