You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/09/02 09:07:58 UTC
[GitHub] zeppelin pull request #1396: [ZEPPELIN-1405] Remove propertyKeyUnusedConnect...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1396
[ZEPPELIN-1405] Remove propertyKeyUnusedConnectionListMap variable in JDBCInterpreter
### What is this PR for?
This PR is for refactoring code for JDBCInterpreter.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1405
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1405
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1396.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1396
----
commit 12dd7cb239cd22cb85d55221a18bbf157665a45a
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-02T09:05:50Z
remove propertyKeyUnusedConnectionListMap map
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] Remove propertyKeyUnusedConnectionList...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1396
\cc @jongyoul Please review this PR if i misunderstand.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpre...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1396
[ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.
### What is this PR for?
This PR is for refactoring code for JDBCInterpreter.
There is no putting 'Connection' to 'propertyKeyUnusedConnectionListMap' anywhere in the original code.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1405
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1405
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1396.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1396
----
commit 12dd7cb239cd22cb85d55221a18bbf157665a45a
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-02T09:05:50Z
remove propertyKeyUnusedConnectionListMap map
commit 4dabbcc98d5f8e8013502ba786ec7f60f115efff
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-04T18:08:36Z
wip) changing to use dbcp
commit 9f1e368fe16ef889715b8a58e9592cb0393ae464
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-05T15:58:25Z
replace ConnectionPool
commit 4d4f85cf1e59aaecbabe025b6c261349c94abe4a
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-05T16:10:41Z
refactoring code of close()
commit 21217a7340438bbd39b75a1dd3756885c4d2d911
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-07T02:06:50Z
fix indentation.
commit efc2bfc2c590ea6ccc3ca99490e326f25a3aa3c4
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-12T14:53:09Z
rebase
commit 1862ae6c694681861a6e51f26960b61478c6df4d
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-21T12:58:38Z
Merge branch 'master' into ZEPPELIN-1405
commit f6998c27ddad2bd93d48a3acbdfca24c698095d6
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-22T12:52:35Z
Merge branch 'master' into ZEPPELIN-1405
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] Remove propertyKeyUnusedConnectionList...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1396
Good!!
On Saturday, 3 September 2016, HyungSung <no...@github.com> wrote:
> I will do it in this PR and change the title this. :)
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/zeppelin/pull/1396#issuecomment-244530155>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ADcflk02U-1wmCZXO3P3cKSDLcjpISYAks5qmROygaJpZM4Jzgoo>
> .
>
--
\uc774\uc885\uc5f4, Jongyoul Lee, \u674e\u5b97\u70c8
http://madeng.net
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] Remove propertyKeyUnusedConnectionList...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1396
I will do it in this PR and change the title this. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1396
I tested `mysql`, `postgresql` and `hive`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpre...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1396
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1396
CI has passed. please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1396
Thanks @jongyoul and there was no problem running mysql.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1396
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpre...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [WIP] [ZEPPELIN-1405] ConnectionPool for JDBCInterpret...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1396
\cc @jongyoul I changed some codes to use `Connection Pool` that is `org.apache.commons.dbcp2`, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpre...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpre...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1396
[ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.
### What is this PR for?
This PR is for refactoring code for JDBCInterpreter.
There is no putting 'Connection' to 'propertyKeyUnusedConnectionListMap' anywhere in the original code.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1405
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1405
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1396.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1396
----
commit 12dd7cb239cd22cb85d55221a18bbf157665a45a
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-02T09:05:50Z
remove propertyKeyUnusedConnectionListMap map
commit 4dabbcc98d5f8e8013502ba786ec7f60f115efff
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-04T18:08:36Z
wip) changing to use dbcp
commit 9f1e368fe16ef889715b8a58e9592cb0393ae464
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-05T15:58:25Z
replace ConnectionPool
commit 4d4f85cf1e59aaecbabe025b6c261349c94abe4a
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-05T16:10:41Z
refactoring code of close()
commit 21217a7340438bbd39b75a1dd3756885c4d2d911
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-07T02:06:50Z
fix indentation.
commit efc2bfc2c590ea6ccc3ca99490e326f25a3aa3c4
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-12T14:53:09Z
rebase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1396
Thanks! I'll look into it. btw, don't you have any problem when you were testing mysql?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpre...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpre...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1396
[ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.
### What is this PR for?
This PR is for refactoring code for JDBCInterpreter.
There is no putting 'Connection' to 'propertyKeyUnusedConnectionListMap' anywhere in the original code.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1405
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1405
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1396.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1396
----
commit 12dd7cb239cd22cb85d55221a18bbf157665a45a
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-02T09:05:50Z
remove propertyKeyUnusedConnectionListMap map
commit 4dabbcc98d5f8e8013502ba786ec7f60f115efff
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-04T18:08:36Z
wip) changing to use dbcp
commit 9f1e368fe16ef889715b8a58e9592cb0393ae464
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-05T15:58:25Z
replace ConnectionPool
commit 4d4f85cf1e59aaecbabe025b6c261349c94abe4a
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-05T16:10:41Z
refactoring code of close()
commit 21217a7340438bbd39b75a1dd3756885c4d2d911
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-07T02:06:50Z
fix indentation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] Remove propertyKeyUnusedConnectionList...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1396
In this PR or separately?
On Saturday, 3 September 2016, HyungSung <no...@github.com> wrote:
> @jongyoul <https://github.com/jongyoul> I will refactor the code to use
> database pool.
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/zeppelin/pull/1396#issuecomment-244529263>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ADcflgJmeDQxwU2fRTGSZURNtH5EZb6Yks5qmQ5ngaJpZM4Jzgoo>
> .
>
--
\uc774\uc885\uc5f4, Jongyoul Lee, \u674e\u5b97\u70c8
http://madeng.net
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] Remove propertyKeyUnusedConnectionList...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1396
@jongyoul I will refactor the code to use database pool.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1396
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] Remove propertyKeyUnusedConnectionList...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1396
@astroshim It doesn't look completed. When are some connections closed? First of all, there's no code for closing connections.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---