You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by Berin Loritsch <bl...@apache.org> on 2001/10/26 21:50:00 UTC

Re: cvs commit: xml-cocoon2/src/org/apache/cocoon/components/xscript XScriptManager.java

>      /**
>       * Return the <code>ComponentManager</code> managing this instance.
>       *
>       * @return a <code>ComponentManager</code> value
>       */
>   -  public ComponentManager getComponentManager();
>   +  ComponentManager getComponentManager();


This part of the API just caught my eye.  Can anyone tell me what purpose
this serves?  I am against this approach as it violates the IoC that we
have so carefully crafted into Cocoon.  If you need a ComponentManager,
implement Composable!  The parent component will/should give it to you.

Basically what I am saying is this:

UNDER NO CIRCUMSTANCES should the ComponentManager be openly available
to all code in the world.  The Components that receive the ComponentManager
must be carefully managed.

We should probably change this soon.

----------------------------------------------------------------------
In case of troubles, e-mail:     webmaster@xml.apache.org
To unsubscribe, e-mail:          cocoon-cvs-unsubscribe@xml.apache.org
For additional commands, e-mail: cocoon-cvs-help@xml.apache.org


Re: cvs commit: xml-cocoon2/src/org/apache/cocoon/components/xscript XScriptManager.java

Posted by Stefano Mazzocchi <st...@apache.org>.
Berin Loritsch wrote:

> UNDER NO CIRCUMSTANCES should the ComponentManager be openly available
> to all code in the world.  The Components that receive the ComponentManager
> must be carefully managed.

+1

-- 
Stefano Mazzocchi      One must still have chaos in oneself to be
                          able to give birth to a dancing star.
<st...@apache.org>                             Friedrich Nietzsche
--------------------------------------------------------------------



---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: cvs commit: xml-cocoon2/src/org/apache/cocoon/components/xscript XScriptManager.java

Posted by giacomo <gi...@apache.org>.
On Fri, 26 Oct 2001, Berin Loritsch wrote:

> >      /**
> >       * Return the <code>ComponentManager</code> managing this instance.
> >       *
> >       * @return a <code>ComponentManager</code> value
> >       */
> >   -  public ComponentManager getComponentManager();
> >   +  ComponentManager getComponentManager();
>
>
> This part of the API just caught my eye.  Can anyone tell me what purpose
> this serves?  I am against this approach as it violates the IoC that we
> have so carefully crafted into Cocoon.  If you need a ComponentManager,
> implement Composable!  The parent component will/should give it to you.
>
> Basically what I am saying is this:
>
> UNDER NO CIRCUMSTANCES should the ComponentManager be openly available
> to all code in the world.  The Components that receive the ComponentManager
> must be carefully managed.
>
> We should probably change this soon.

I stronly support Berins oppinion on this. Ovidiu, can you explain this
methods usage intention?

Giacomo


----------------------------------------------------------------------
In case of troubles, e-mail:     webmaster@xml.apache.org
To unsubscribe, e-mail:          cocoon-cvs-unsubscribe@xml.apache.org
For additional commands, e-mail: cocoon-cvs-help@xml.apache.org


Re: cvs commit: xml-cocoon2/src/org/apache/cocoon/components/xscript XScriptManager.java

Posted by giacomo <gi...@apache.org>.
On Fri, 26 Oct 2001, Berin Loritsch wrote:

> >      /**
> >       * Return the <code>ComponentManager</code> managing this instance.
> >       *
> >       * @return a <code>ComponentManager</code> value
> >       */
> >   -  public ComponentManager getComponentManager();
> >   +  ComponentManager getComponentManager();
>
>
> This part of the API just caught my eye.  Can anyone tell me what purpose
> this serves?  I am against this approach as it violates the IoC that we
> have so carefully crafted into Cocoon.  If you need a ComponentManager,
> implement Composable!  The parent component will/should give it to you.
>
> Basically what I am saying is this:
>
> UNDER NO CIRCUMSTANCES should the ComponentManager be openly available
> to all code in the world.  The Components that receive the ComponentManager
> must be carefully managed.
>
> We should probably change this soon.

I stronly support Berins oppinion on this. Ovidiu, can you explain this
methods usage intention?

Giacomo


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org