You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/02/10 06:27:13 UTC
[GitHub] [cordova-ios] erisu opened a new pull request #780: breaking:
upgrade xcode compatible to 9.3
erisu opened a new pull request #780: breaking: upgrade xcode compatible to 9.3
URL: https://github.com/apache/cordova-ios/pull/780
### Motivation and Context
Upgrade project, CordovaLib, and CordovaLib test to be Xcode 9.3 compatible.
Keeping it modern, or as modern as possible with our target release.
[WWDC 2016 Video](https://developer.apple.com/videos/play/wwdc2019/239/), as Apple says, around `6:15` minute mark:
> Keeping your project file modern is a critical way to make sure that Xcode can help you out and avoids the accumulation of issues.
> First, when you're updating to a new version of Xcode, you'll be offered the opportunity sometimes to have **Xcode update the project settings and update your project file to the latest format**.
### Description
* Change the `Project Format` to `Xcode 9.3-compatible`.
For easy review process, please look specifically at the contents from the commit: `breaking: upgrade xcode compatible to 9.3`.
This PR is branched off of PR #779 and PR #779 will need to be merged in first.
### Testing
- `npm t`
- `cordova platform add`
- `cordova build ios`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu edited a comment on issue #780: breaking:
upgrade xcode compatible to 11.0
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on issue #780: breaking: upgrade xcode compatible to 11.0
URL: https://github.com/apache/cordova-ios/pull/780#issuecomment-584919931
The changes in this PR were made though the Xcode interface. Nothing was manually changed except to re-add back quotation wrappers around the product name for UTF-8 support. I believe `LastUpgradeCheck` shouldn't be manually changed.
Xcode should have updated it if it was needed. I am guessing that Xcode did not change `LastUpgradeCheck` because it was not triggered by an upgrade notification.
If we manually changed it, we would need to know the correct value.
* What would be the side-effect of changing it manually?
* If not everything was upgraded and it was manually changed, would it be basically be disabling the flag that Xcode might used to determining to display an upgrade notification? And if disabled and if there were missed changes, would they not be corrected?
Anyways, I think it is safe to keep it as is and wait till next time Xcode automatically updates this for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on issue #780: breaking: upgrade
xcode compatible to 11.0
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #780: breaking: upgrade xcode compatible to 11.0
URL: https://github.com/apache/cordova-ios/pull/780#issuecomment-586107515
Last call, this PR will be merged with or without a review in 24 hours.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] BBosman commented on issue #780: breaking: upgrade
xcode compatible to 11.0
Posted by GitBox <gi...@apache.org>.
BBosman commented on issue #780: breaking: upgrade xcode compatible to 11.0
URL: https://github.com/apache/cordova-ios/pull/780#issuecomment-584230931
I would have expected the “LastUpgradeCheck” to reference the XCode 11 level as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu merged pull request #780: breaking: upgrade
xcode compatible to 11.0
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #780: breaking: upgrade xcode compatible to 11.0
URL: https://github.com/apache/cordova-ios/pull/780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu edited a comment on issue #780: breaking:
upgrade xcode compatible to 11.0
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on issue #780: breaking: upgrade xcode compatible to 11.0
URL: https://github.com/apache/cordova-ios/pull/780#issuecomment-584919931
The changes in this PR were made though the Xcode interface. Nothing was manually changed except to re-add back quotation wrappers around the product name for UTF-8 support. I believe `LastUpgradeCheck` shouldn't be manually changed.
Xcode should have updated it if it was needed. I am guessing that Xcode did not change `LastUpgradeCheck` because it was not triggered by an upgrade notification.
If we manually changed it, we would need to know the correct value.
* What would be the side-effect of changing it manually?
* If not everything was upgraded and it was manually changed it, would it be basically disabling potentially the only flag used to determining to display an upgrade or to make additional missing changes that are needed?
Anyways, I think it is safe to keep it as is and wait till next time Xcode automatically updates this for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] jcesarmobile commented on issue #780: breaking:
upgrade xcode compatible to 9.3
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on issue #780: breaking: upgrade xcode compatible to 9.3
URL: https://github.com/apache/cordova-ios/pull/780#issuecomment-584082014
Why Xcode 9? Apple requires Xcode 10 for submissions, and soon (by April) they will require Xcode 11.
So maybe we can target Xcode 11 already and remove Xcode 10 and earlier from tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #780: breaking:
upgrade xcode compatible to 9.3
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #780: breaking: upgrade xcode compatible to 9.3
URL: https://github.com/apache/cordova-ios/pull/780#issuecomment-583977200
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=h1) Report
> Merging [#780](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/59d0dd712ff362e5165ce9a50f078425f83e637d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #780 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 11 11
Lines 1815 1815
=======================================
Hits 1348 1348
Misses 467 467
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=footer). Last update [59d0dd7...edf870f](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io commented on issue #780: breaking: upgrade
xcode compatible to 9.3
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #780: breaking: upgrade xcode compatible to 9.3
URL: https://github.com/apache/cordova-ios/pull/780#issuecomment-583977200
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=h1) Report
> Merging [#780](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/240a177d9dd5966768c20ab14920b708af3baa0b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #780 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 11 11
Lines 1815 1815
=======================================
Hits 1348 1348
Misses 467 467
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/780/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=) | `73.58% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=footer). Last update [240a177...66eb78d](https://codecov.io/gh/apache/cordova-ios/pull/780?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on issue #780: breaking: upgrade
xcode compatible to 11.0
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #780: breaking: upgrade xcode compatible to 11.0
URL: https://github.com/apache/cordova-ios/pull/780#issuecomment-584919931
The changes in this PR were made though the Xcode interface. Nothing was manually changed except to re-add back quotation wrappers around the product name for UTF-8 support. I believe `LastUpgradeCheck` shouldn't be manually changed.
Xcode should have updated it if it was needed. It was not changed because it was not though an upgrade notification.
If we manually changed it, we would need to know the correct value.
* What would be the side-effect of changing it manually?
* If not everything was upgraded and it was manually changed it, would it be basically disabling potentially the only flag used to determining to display an upgrade or to make additional missing changes that are needed?
Anyways, I think it is safe to keep it as is and wait till next time Xcode automatically updates this for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu edited a comment on issue #780: breaking:
upgrade xcode compatible to 11.0
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on issue #780: breaking: upgrade xcode compatible to 11.0
URL: https://github.com/apache/cordova-ios/pull/780#issuecomment-584919931
The changes in this PR were made though the Xcode interface. Nothing was manually changed except to re-add back quotation wrappers around the product name for UTF-8 support. I believe `LastUpgradeCheck` shouldn't be manually changed.
Xcode should have updated it if it was needed. I am guessing that Xcode did not change `LastUpgradeCheck` because it was not triggered by an upgrade notification.
If we manually changed it, we would need to know the correct value.
* What would be the side-effect of changing it manually?
* If not everything was upgraded and it was manually changed, would it be basically be disabling the flag that Xcode might used to determining to display an upgrade notification? And if disabled and if there were missed changes, would they not be corrected?
Anyways, I think it is safer to keep it as is and wait till Xcode automatically updates this for us.
Actually, I have another PR that I am preparing that did update `LastUpgradeCheck` though the Xcode UI. Those changes will not be merged with this PR and will be treated as a separate change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on issue #780: breaking: upgrade
xcode compatible to 9.3
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #780: breaking: upgrade xcode compatible to 9.3
URL: https://github.com/apache/cordova-ios/pull/780#issuecomment-584091318
I forgot all about the new submission rules from Apple. I will go ahead and update to Xcode 11 to follow the submission rule which is described on this page.
https://developer.apple.com/app-store/submissions/
> Starting April, 2020, all apps submitted to the App Store will need to be built with Xcode 11. Xcode 11 requires macOS Mojave 10.14.3 or later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org