You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2021/08/24 02:33:06 UTC
[spark] branch master updated: [SPARK-35991][SQL][FOLLOWUP] Add
back protected modifier of sparkConf to TPCBase
This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new e83f8a8 [SPARK-35991][SQL][FOLLOWUP] Add back protected modifier of sparkConf to TPCBase
e83f8a8 is described below
commit e83f8a872a16d4f049cefb1fc445f91cf84443ad
Author: Angerszhuuuu <an...@gmail.com>
AuthorDate: Tue Aug 24 11:32:30 2021 +0900
[SPARK-35991][SQL][FOLLOWUP] Add back protected modifier of sparkConf to TPCBase
### What changes were proposed in this pull request?
Add back protected modifier of sparkConf to TPCBase according to https://github.com/apache/spark/pull/33736/files#r694054229
### Why are the changes needed?
Add back protected modifier of sparkConf to TPCBase
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Not need
Closes #33813 from AngersZhuuuu/SPARK-35991-FOLLOWUP.
Authored-by: Angerszhuuuu <an...@gmail.com>
Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
sql/core/src/test/scala/org/apache/spark/sql/TPCBase.scala | 2 +-
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala | 2 +-
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQueryTestSuite.scala | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/TPCBase.scala b/sql/core/src/test/scala/org/apache/spark/sql/TPCBase.scala
index b1ea70d..1764584 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/TPCBase.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/TPCBase.scala
@@ -25,7 +25,7 @@ trait TPCBase extends SharedSparkSession {
protected def injectStats: Boolean = false
- override def sparkConf: SparkConf = {
+ override protected def sparkConf: SparkConf = {
if (injectStats) {
super.sparkConf
.set(SQLConf.MAX_TO_STRING_FIELDS, Int.MaxValue)
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala
index cab117c..22e1b83 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala
@@ -73,6 +73,6 @@ class TPCDSQueryWithStatsSuite extends TPCDSQuerySuite {
@ExtendedSQLTest
class TPCDSQueryANSISuite extends TPCDSQuerySuite {
- override def sparkConf: SparkConf =
+ override protected def sparkConf: SparkConf =
super.sparkConf.set(SQLConf.ANSI_ENABLED, true)
}
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/TPCDSQueryTestSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/TPCDSQueryTestSuite.scala
index 0f16d25..3e7f898 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/TPCDSQueryTestSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/TPCDSQueryTestSuite.scala
@@ -57,7 +57,7 @@ class TPCDSQueryTestSuite extends QueryTest with TPCDSBase with SQLQueryTestHelp
private val regenerateGoldenFiles = sys.env.get("SPARK_GENERATE_GOLDEN_FILES").exists(_ == "1")
// To make output results deterministic
- override def sparkConf: SparkConf = super.sparkConf
+ override protected def sparkConf: SparkConf = super.sparkConf
.set(SQLConf.SHUFFLE_PARTITIONS.key, "1")
protected override def createSparkSession: TestSparkSession = {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org