You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Gary Smith (JIRA)" <ji...@apache.org> on 2012/10/04 23:11:47 UTC

[jira] [Created] (CB-1587) Wrong splash screen shown on iPhone 5

Gary Smith created CB-1587:
------------------------------

             Summary: Wrong splash screen shown on iPhone 5
                 Key: CB-1587
                 URL: https://issues.apache.org/jira/browse/CB-1587
             Project: Apache Cordova
          Issue Type: Bug
          Components: iOS
    Affects Versions: 2.1.0
            Reporter: Gary Smith
            Assignee: Shazron Abdullah
            Priority: Minor


When running on a iPhone 5, the Splash screen show is the Default.png instead of the Default-568h.png file. 

To fix, in the CDVViewController.m file, in the showSplashScreen function, look for this bit of code:


else // not iPad
{
    orientedLaunchImageFile = launchImageFile;
}


and change it to

else // not iPad
{
   if ( [UIScreen mainScreen].bounds.size.height == 568 ) // or some other method of determining if on iPhone 5
   {
      orientedLaunchImageFile = [NSString stringWithFormat:@"%@-568h", launchImageFile];
   }
   else
   {
       orientedLaunchImageFile = launchImageFile;
   }
}



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CB-1587) Wrong splash screen shown on iPhone 5

Posted by "Becky Gibson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Becky Gibson resolved CB-1587.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2.0

Shaz fixed this - see comments for commit details.
                
> Wrong splash screen shown on iPhone 5
> -------------------------------------
>
>                 Key: CB-1587
>                 URL: https://issues.apache.org/jira/browse/CB-1587
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 2.1.0
>            Reporter: Gary Smith
>            Assignee: Shazron Abdullah
>            Priority: Minor
>              Labels: bug, iPhone5, ios, splashscreen
>             Fix For: 2.2.0
>
>
> When running on a iPhone 5, the Splash screen show is the Default.png instead of the Default-568h.png file. 
> To fix, in the CDVViewController.m file, in the showSplashScreen function, look for this bit of code:
> else // not iPad
> {
>     orientedLaunchImageFile = launchImageFile;
> }
> and change it to
> else // not iPad
> {
>    if ( [UIScreen mainScreen].bounds.size.height == 568 ) // or some other method of determining if on iPhone 5
>    {
>       orientedLaunchImageFile = [NSString stringWithFormat:@"%@-568h", launchImageFile];
>    }
>    else
>    {
>        orientedLaunchImageFile = launchImageFile;
>    }
> }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1587) Wrong splash screen shown on iPhone 5

Posted by "Becky Gibson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471642#comment-13471642 ] 

Becky Gibson commented on CB-1587:
----------------------------------

This has been fixed with the following two commits:
 * https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=ca705097d8b299d2d45814f19defa626c991d0bf

 * https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=1dd9b330c4f7e613e93525b21a10e4ee20984cc4
                
> Wrong splash screen shown on iPhone 5
> -------------------------------------
>
>                 Key: CB-1587
>                 URL: https://issues.apache.org/jira/browse/CB-1587
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 2.1.0
>            Reporter: Gary Smith
>            Assignee: Shazron Abdullah
>            Priority: Minor
>              Labels: bug, iPhone5, ios, splashscreen
>             Fix For: 2.2.0
>
>
> When running on a iPhone 5, the Splash screen show is the Default.png instead of the Default-568h.png file. 
> To fix, in the CDVViewController.m file, in the showSplashScreen function, look for this bit of code:
> else // not iPad
> {
>     orientedLaunchImageFile = launchImageFile;
> }
> and change it to
> else // not iPad
> {
>    if ( [UIScreen mainScreen].bounds.size.height == 568 ) // or some other method of determining if on iPhone 5
>    {
>       orientedLaunchImageFile = [NSString stringWithFormat:@"%@-568h", launchImageFile];
>    }
>    else
>    {
>        orientedLaunchImageFile = launchImageFile;
>    }
> }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira