[GitHub] [hadoop] ayushtkn commented on a change in pull request #3328: HDFS-16183. RBF: Delete unnecessary metric of proxyOpComplete in routerRpcClient

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #3328:
URL: https://github.com/apache/hadoop/pull/3328#discussion_r697444399



##########
File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
##########
@@ -517,7 +517,6 @@ private Object invokeMethod(
           // Communication retries are handled by the retry policy
           if (this.rpcMonitor != null) {
             this.rpcMonitor.proxyOpFailureCommunicate();
-            this.rpcMonitor.proxyOpComplete(false);

Review comment:
       @wzhallright  can add a LOG for the exception in this case as well, removal of `proxyOpComplete`   is OK.
   something like
   ```
             LOG.error("Cannot connect to the namenode for {}  at {}", nsId,
                 rpcAddress, ioe);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org