You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Dong Li (JIRA)" <ji...@apache.org> on 2018/01/01 14:44:00 UTC
[jira] [Resolved] (KYLIN-3143) Wrong use of
Preconditions.checkNotNull() in ManagedUser#removeAuthoritie
[ https://issues.apache.org/jira/browse/KYLIN-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dong Li resolved KYLIN-3143.
----------------------------
Resolution: Fixed
Fix Version/s: v2.3.0
merged to master branch.
> Wrong use of Preconditions.checkNotNull() in ManagedUser#removeAuthoritie
> -------------------------------------------------------------------------
>
> Key: KYLIN-3143
> URL: https://issues.apache.org/jira/browse/KYLIN-3143
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Chao Long
> Priority: Minor
> Fix For: v2.3.0
>
> Attachments: KYLIN-3143-THE-RIGHT-WAY-TO-USE-PRECONDITIONS-CHECKOUTNOTNULL.patch
>
>
> {code}
> public void removeAuthoritie(String auth) {
> Preconditions.checkNotNull(this.authorities == null);
> {code}
> I think the intention was to check this.authorities, not {{this.authorities == null}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)