[GitHub] ningyougang commented on a change in pull request #4164: Add warn log when too many requests happened

[GitBox <gi...@apache.org>]

ningyougang commented on a change in pull request #4164: Add warn log when too many requests happened
URL: https://github.com/apache/incubator-openwhisk/pull/4164#discussion_r245536869
 
 

 ##########
 File path: core/controller/src/main/scala/org/apache/openwhisk/core/controller/AuthorizedRouteDispatcher.scala
 ##########
 @@ -86,7 +89,11 @@ trait BasicAuthorizedRouteProvider extends Directives {
               case NotFound =>
                 handleEntitlementFailure(
                   RejectRequest(NotFound, Some(ErrorResponse(Messages.resourceDoesntExist(resource.fqname), transid))))
-              case _ => handleEntitlementFailure(t)
+              case code =>
+                if (code == TooManyRequests) {
+                  logger.warn(this, s"${resource.id} invoked failed: ${t}")
+                }
 
 Review comment:
   @rabbah ,in above codes, didn't include action info. for example, we don't know which action leads to that.
   In some scene, except namespace info, user may want to know the detail action info also.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services