You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "igor-dv (via GitHub)" <gi...@apache.org> on 2026/10/04 21:27:47 UTC
[PR] [Go SDK] wrap a failed last data/timer send like Flush [beam]
igor-dv opened a new pull request, #40406:
URL: https://github.com/apache/beam/pull/40406
fixes #40405
Add "errors.Wrapf" for the last send error in dataWriter.Close and timerWriter.Close()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Go SDK] wrap a failed last data/timer send like Flush [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40406:
URL: https://github.com/apache/beam/pull/40406#issuecomment-5985022005
Assigning reviewers:
R: @lostluck for label go.
This pull request likely touches a core component ("core" label). Please review with scrutiny.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Go SDK] wrap a failed last data/timer send like Flush [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40406:
URL: https://github.com/apache/beam/pull/40406#issuecomment-6109028794
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/40406?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.63%. Comparing base ([`76f6e6d`](https://app.codecov.io/gh/apache/beam/commit/76f6e6d7c0c1b2ce582c73d068ad9260cf15c5f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4ac2e09`](https://app.codecov.io/gh/apache/beam/commit/4ac2e09c39c6577e0433da4535b299d0f3bda8de?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 111 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/beam/pull/40406?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [sdks/go/pkg/beam/core/runtime/harness/datamgr.go](https://app.codecov.io/gh/apache/beam/pull/40406?src=pr&el=tree&filepath=sdks%2Fgo%2Fpkg%2Fbeam%2Fcore%2Fruntime%2Fharness%2Fdatamgr.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvaGFybmVzcy9kYXRhbWdyLmdv) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/40406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40406 +/- ##
============================================
+ Coverage 56.16% 57.63% +1.46%
Complexity 2288 2288
============================================
Files 1124 1125 +1
Lines 178336 167497 -10839
Branches 1489 1489
============================================
- Hits 100170 96539 -3631
+ Misses 75645 68419 -7226
- Partials 2521 2539 +18
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/40406/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [go](https://app.codecov.io/gh/apache/beam/pull/40406/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `28.46% <66.66%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/beam/pull/40406?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Go SDK] wrap a failed last data/timer send like Flush [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #40406:
URL: https://github.com/apache/beam/pull/40406#issuecomment-6132280220
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Go SDK] wrap a failed last data/timer send like Flush [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #40406:
URL: https://github.com/apache/beam/pull/40406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Go SDK] wrap a failed last data/timer send like Flush [beam]
Posted by "igor-dv (via GitHub)" <gi...@apache.org>.
igor-dv commented on PR #40406:
URL: https://github.com/apache/beam/pull/40406#issuecomment-6110881135
Thanks @damccorm. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org