You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by "Himakar (via GitHub)" <gi...@apache.org> on 2024/07/10 09:55:00 UTC
[PR] Issue #1499: Deleted Quartz module. [shiro]
Himakar opened a new pull request, #1581:
URL: https://github.com/apache/shiro/pull/1581
Fixed Issue #1499: Quartz module deletion
The module was present in shiro\support folder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "fpapon (via GitHub)" <gi...@apache.org>.
fpapon commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2293781689
The 4 commits from dependabot are from main and not from 3.x.
You can remove them with `git rebase -i HEAD~5` and drop them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2267258292
@Himakar Any updates please?
We have created 3.x branch and can merge this if you make the necessary changes.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "Himakar (via GitHub)" <gi...@apache.org>.
Himakar commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2276241294
I did squash and push latest squash to the Git Hub. Also i created a pull request (Is it not necessary to create Pull request every time i do changes)
@lprimak, Thank you very much for your patience. I learned some Git hub concepts because of you.
If still i need to do any changes, please let me know.
Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #1499: Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1581:
URL: https://github.com/apache/shiro/pull/1581#discussion_r1674393388
##########
test-coverage/pom.xml:
##########
@@ -89,16 +89,10 @@
<groupId>org.apache.shiro</groupId>
<artifactId>shiro-hazelcast</artifactId>
</dependency>
-
Review Comment:
Please restore this whitespace. (I know... nit :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "Himakar (via GitHub)" <gi...@apache.org>.
Himakar commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2291432043
Hi @lprimak ,
I can see the commit items in the pull request. Am i missing something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "fpapon (via GitHub)" <gi...@apache.org>.
fpapon commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2292909486
@Himakar I think you need to rebase your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #1499: Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2253459690
@Himakar Can you please fix the remaining issues as described above please?
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2274863391
1. Just read the PR description. There are checkboxes there about license agreement. Read and click on the appropriate checkboxes.
2. See https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2276784311
No problem! Somehow your squashed changes didn't "take" on this PR. Please don't create new PRs, and use this PR.
Please try squashing / force-push this PR again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2276785395
Also, I based this branch of the 3.x branch now, please make a note of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2292026067
Your screenshot points to the *closed* PR. You need to squash commits on **this** PR. It still shows 7 commits.
Also, now there is a conflict that needs to be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "Himakar (via GitHub)" <gi...@apache.org>.
Himakar commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2273111093
Hi @lprimak, Could you please let me know hint on CLA checkboxes and squash part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2294520980
Awesome! We are happy to help. Thanks and keep it up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "fpapon (via GitHub)" <gi...@apache.org>.
fpapon commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2295786570
@Himakar you're welcome and don't hesitate to make other proposal!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2289510575
@Himakar Any updates? We are so close :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #1499: Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2220884030
Yea, I think not having 3.x branch is starting to block things...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2270159969
@Himakar Last thing you have to do is to click the CLA checkbox(es) and squash the commits.
Do you know how to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "Himakar (via GitHub)" <gi...@apache.org>.
Himakar commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2293769264
Hi @fpapon, Thanks for your help. Now i have rebased my branch from 3.x branch and pushed code.
Is this fine now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #1499: Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2220885582
@Himakar Can you fix the failing build please? I think it's just a matter of removing quartz from the coverage module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #1499: Deleted Quartz module. [shiro]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2220658478
Note: We need to wait until we cut the 3.x branch before merging this (but we can get it ready to go!).
My pref would be to hold off creating the branch until we have a few PRs lined up that depend on each (as to avoid any additional back porting), but... avoiding backporting might just be a dream 😆
(I'm also not trying to block anyone from cutting the 3.x branch if they are motivated) 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "Himakar (via GitHub)" <gi...@apache.org>.
Himakar commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2294517649
Hi @lprimak , @fpapon ,
Thank you for your help. It means a lot to me.
I am learning new concepts because of this task.
Thank you once again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "fpapon (via GitHub)" <gi...@apache.org>.
fpapon commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2293536072
@Himakar you are rebasing from `main` rather than `3.x` branch, this is why you added more recent commit from main.
You need to be sync to `3.x` branch and not `main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1499] - Deleted Quartz module. [shiro]
Posted by "fpapon (via GitHub)" <gi...@apache.org>.
fpapon merged PR #1581:
URL: https://github.com/apache/shiro/pull/1581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #1499: Deleted Quartz module. [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1581:
URL: https://github.com/apache/shiro/pull/1581#issuecomment-2223492762
Also, please squash the commits into one.
Otherwise, LGTM, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org