[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #7120: [ISSUE #7064] [RIP-66-2] Support KV(RocksDB) Storage for ConsumeQueue

["RongtongJin (via GitHub)" <gi...@apache.org>]

RongtongJin commented on code in PR #7120:
URL: https://github.com/apache/rocketmq/pull/7120#discussion_r1293228982


##########
store/src/main/java/org/apache/rocketmq/store/MessageStore.java:
##########
@@ -693,14 +704,20 @@ void onCommitLogDispatch(DispatchRequest dispatchRequest, boolean doDispatch, Ma
      * Truncate dirty logic files
      *
      * @param phyOffset physical offset
+     * @throws RocksDBException only in rocksdb mode
      */
-    void truncateDirtyLogicFiles(long phyOffset);
+    void truncateDirtyLogicFiles(long phyOffset) throws RocksDBException;
 
     /**
      * Destroy logics files
      */
     void destroyLogics();
 
+    /**
+     * Load logics files
+     */
+    boolean loadLogics();

Review Comment:
   It would be better to move this method to consumeQueueStore



##########
store/src/main/java/org/apache/rocketmq/store/MessageStore.java:
##########
@@ -973,4 +992,21 @@ DispatchRequest checkMessageAndReturnSize(final ByteBuffer byteBuffer, final boo
      * @param attributesBuilderSupplier metrics attributes builder
      */
     void initMetrics(Meter meter, Supplier<AttributesBuilder> attributesBuilderSupplier);
+
+    /**
+     * Recover topic queue table
+     */
+    void recoverTopicQueueTable();
+
+    /**
+     * Get store time from commitlog by cqUnit
+     * @param cqUnit
+     * @return
+     */
+    long getStoreTime(CqUnit cqUnit);

Review Comment:
   It would be better to move this method to consumeQueueStore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org