You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2021/06/22 21:33:42 UTC
[qpid-protonj2] 02/02: PROTON-2398 Fix a minor copy issue in Header
and add test coverage
This is an automated email from the ASF dual-hosted git repository.
tabish pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-protonj2.git
commit 10183a1820a3e979b0dc1f38f7f3039696b579a4
Author: Timothy Bish <ta...@gmail.com>
AuthorDate: Tue Jun 22 17:33:18 2021 -0400
PROTON-2398 Fix a minor copy issue in Header and add test coverage
---
.../main/java/org/apache/qpid/protonj2/types/messaging/Header.java | 1 +
.../java/org/apache/qpid/protonj2/types/messaging/HeaderTest.java | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/protonj2/src/main/java/org/apache/qpid/protonj2/types/messaging/Header.java b/protonj2/src/main/java/org/apache/qpid/protonj2/types/messaging/Header.java
index dd73006..8ed76a5 100644
--- a/protonj2/src/main/java/org/apache/qpid/protonj2/types/messaging/Header.java
+++ b/protonj2/src/main/java/org/apache/qpid/protonj2/types/messaging/Header.java
@@ -56,6 +56,7 @@ public final class Header implements Section<Header> {
this.timeToLive = other.timeToLive;
this.firstAcquirer = other.firstAcquirer;
this.deliveryCount = other.deliveryCount;
+ this.modified = other.modified;
}
public Header copy() {
diff --git a/protonj2/src/test/java/org/apache/qpid/protonj2/types/messaging/HeaderTest.java b/protonj2/src/test/java/org/apache/qpid/protonj2/types/messaging/HeaderTest.java
index 9bc15e9..7c4453b 100644
--- a/protonj2/src/test/java/org/apache/qpid/protonj2/types/messaging/HeaderTest.java
+++ b/protonj2/src/test/java/org/apache/qpid/protonj2/types/messaging/HeaderTest.java
@@ -81,6 +81,8 @@ public class HeaderTest {
header.setFirstAcquirer(!Header.DEFAULT_FIRST_ACQUIRER);
header.setDeliveryCount(Header.DEFAULT_DELIVERY_COUNT + 5);
+ assertFalse(header.isEmpty());
+
Header copy = header.copy();
assertEquals(!Header.DEFAULT_DURABILITY, copy.isDurable());
@@ -88,6 +90,8 @@ public class HeaderTest {
assertEquals(Header.DEFAULT_TIME_TO_LIVE - 10, copy.getTimeToLive());
assertEquals(!Header.DEFAULT_FIRST_ACQUIRER, copy.isFirstAcquirer());
assertEquals(Header.DEFAULT_DELIVERY_COUNT + 5, copy.getDeliveryCount());
+
+ assertFalse(header.isEmpty());
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org