[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9068: [multistage] add more query types for testing

[GitBox <gi...@apache.org>]

siddharthteotia commented on code in PR #9068:
URL: https://github.com/apache/pinot/pull/9068#discussion_r923723588


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTest.java:
##########
@@ -206,6 +207,11 @@ private Object[][] provideTestSqlAndRowCount() {
         // only 3 GROUP BY key exist because b.col2 cycles between "foo", "bar", "alice".
         new Object[]{"SELECT a.col1, SUM(b.col3) FROM a JOIN b ON a.col1 = b.col2 "
             + " WHERE a.col3 >= 0 GROUP BY a.col1", 3},
+
+        // Sub-query

Review Comment:
   Does it make sense to add some form of error handling (at least for the timebeing or initial few usages) to prevent users from trying all kinds of subqueries ? IIRC from one of our discussions, we don't want to support all of subquery and/or join + subquery yet in the multi-stage engine. So may be a reasonable SQL exception for unsupported queries ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org