You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sadanand48 (via GitHub)" <gi...@apache.org> on 2024/01/23 08:25:55 UTC
[PR] HDDS-9065. [FSO]ListKeys: Incorrect result when keyPrefix matching multiple exist keys. [ozone]
sadanand48 opened a new pull request, #6072:
URL: https://github.com/apache/ozone/pull/6072
## What changes were proposed in this pull request?
Fix cases when the keyPrefix pertains to a particular file/dir
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9065
## How was this patch tested?
Unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9065. [FSO]ListKeys: Incorrect result when keyPrefix matching multiple exist keys. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #6072:
URL: https://github.com/apache/ozone/pull/6072#discussion_r1470689892
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java:
##########
@@ -81,6 +81,7 @@ OzoneFileStatus apply(OmKeyArgs args, String clientAddress,
this.omDefaultReplication = omDefaultReplication;
}
+ @SuppressWarnings("methodlength")
Review Comment:
Thanks , I have refactored the method now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9065. [FSO]ListKeys: Incorrect result when keyPrefix matching multiple exist keys. [ozone]
Posted by "aryangupta1998 (via GitHub)" <gi...@apache.org>.
aryangupta1998 commented on PR #6072:
URL: https://github.com/apache/ozone/pull/6072#issuecomment-1923316965
Thanks @sadanand48 for the patch, @TaiJuWu, @adoroszlai, and @whbing for the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9065. [FSO]ListKeys: Incorrect result when keyPrefix matching multiple exist keys. [ozone]
Posted by "aryangupta1998 (via GitHub)" <gi...@apache.org>.
aryangupta1998 merged PR #6072:
URL: https://github.com/apache/ozone/pull/6072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9065. [FSO]ListKeys: Incorrect result when keyPrefix matching multiple exist keys. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on PR #6072:
URL: https://github.com/apache/ozone/pull/6072#issuecomment-1916215235
> I'm not sure if there is a similar problem in listStatusLight
Thanks for the review @whbing , listStatusLight calls listStatus internally, It only trims the keyInfo object to be sent over the wire.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9065. [FSO]ListKeys: Incorrect result when keyPrefix matching multiple exist keys. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #6072:
URL: https://github.com/apache/ozone/pull/6072#discussion_r1468475188
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java:
##########
@@ -81,6 +81,7 @@ OzoneFileStatus apply(OmKeyArgs args, String clientAddress,
this.omDefaultReplication = omDefaultReplication;
}
+ @SuppressWarnings("methodlength")
Review Comment:
Maybe even can be split into several methods (validate parameters, handle different cases, collect results, etc.).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9065. [FSO]ListKeys: Incorrect result when keyPrefix matching multiple exist keys. [ozone]
Posted by "whbing (via GitHub)" <gi...@apache.org>.
whbing commented on PR #6072:
URL: https://github.com/apache/ozone/pull/6072#issuecomment-1910105519
@sadanand48 Thanks for working on this ! Overall looks good.
Since this issue has been around for a long time, a similar method `listStatusLight` has been added , and I'm not sure if there is a similar problem in `listStatusLight`. Such as follow:
https://github.com/apache/ozone/blob/2434689ff3287a407a29823cc16723b29598230b/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java#L1638-L1639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9065. [FSO]ListKeys: Incorrect result when keyPrefix matching multiple exist keys. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on PR #6072:
URL: https://github.com/apache/ozone/pull/6072#issuecomment-1907558934
@whbing would you like to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9065. [FSO]ListKeys: Incorrect result when keyPrefix matching multiple exist keys. [ozone]
Posted by "whbing (via GitHub)" <gi...@apache.org>.
whbing commented on code in PR #6072:
URL: https://github.com/apache/ozone/pull/6072#discussion_r1466312772
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java:
##########
@@ -81,6 +81,7 @@ OzoneFileStatus apply(OmKeyArgs args, String clientAddress,
this.omDefaultReplication = omDefaultReplication;
}
+ @SuppressWarnings("methodlength")
Review Comment:
NIT: To avoid reaching methodlength, perhaps we can organize the code a bit. We can eliminate some unnecessary line breaks because there is no longer an 80-character line limit. Such as the following.
https://github.com/apache/ozone/blob/2434689ff3287a407a29823cc16723b29598230b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java#L96-L102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9065. [FSO]ListKeys: Incorrect result when keyPrefix matching multiple exist keys. [ozone]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #6072:
URL: https://github.com/apache/ozone/pull/6072#discussion_r1467415446
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java:
##########
@@ -81,6 +81,7 @@ OzoneFileStatus apply(OmKeyArgs args, String clientAddress,
this.omDefaultReplication = omDefaultReplication;
}
+ @SuppressWarnings("methodlength")
Review Comment:
Is there a good tool which can help us format this project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org