[GitHub] [calcite] ILuffZhe commented on a diff in pull request #3241: [CALCITE-5745] CONCAT2 function (enabled in Oracle library) gets wrong result when one of the arguments is NULL

["ILuffZhe (via GitHub)" <gi...@apache.org>]

ILuffZhe commented on code in PR #3241:
URL: https://github.com/apache/calcite/pull/3241#discussion_r1221637355


##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -844,12 +844,18 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding operatorBinding,
   /** The "CONCAT(arg0, arg1)" function that concatenates strings.
    * For example, "CONCAT('a', 'bc')" returns "abc".
    *
+   * If one of the argument is null, it will be treated as empty string.

Review Comment:
   Whoops, missed it. Done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org