[GitHub] [hbase] huaxiangsun commented on a change in pull request #1734: HBASE-24376 MergeNormalizer is merging non-adjacent regions and causi…

[GitBox <gi...@apache.org>]

huaxiangsun commented on a change in pull request #1734:
URL: https://github.com/apache/hbase/pull/1734#discussion_r426909067



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizerOnCluster.java
##########
@@ -179,6 +182,71 @@ void testRegionNormalizationSplitOnCluster(boolean limitedByQuota) throws Except
     admin.deleteTable(TABLENAME);
   }
 
+  // This test is to make sure that normalizer is only going to merge adjacent regions.
+  @Test
+  @SuppressWarnings("deprecation")

Review comment:
       There is no better way to copy families/values from an existing table descriptor, I tried to use a non-deprecated method, but ModifyableTableDescriptor(tableName, admin.getDescriptor(tableName)) is the best one, which is deprecated. It is important to keep all the parameters to keep previous written data.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org