[GitHub] sklassen commented on a change in pull request #27: vm.args is now editable -- enabling clusters; snap set works for name and cookie

[GitBox <gi...@apache.org>]

sklassen commented on a change in pull request #27: vm.args is now editable -- enabling clusters; snap set works for name and cookie 
URL: https://github.com/apache/couchdb-pkg/pull/27#discussion_r226813606
 
 

 ##########
 File path: snap/snapcraft.yaml
 ##########
 @@ -9,17 +9,17 @@ apps:
     server:
         daemon: simple
         command: rel/couchdb/bin/snap_run
-        plugs: [network-bind, process-control, mount-observe, browser-support]
+        plugs: [network-bind, process-control, mount-observe]
     couchdb:
         command: rel/couchdb/bin/snap_run
-        plugs: [network-bind]
+        plugs: [network-bind,browser-support]
 parts:
     couchdb: 
         plugin: make
-        #source: http://www-us.apache.org/dist/couchdb/source/2.0.0/apache-couchdb-2.0.0.tar.gz
-        source: https://github.com/apache/couchdb.git
-        source-type: git
-        source-tag: 2.1.0
+        source: http://www-us.apache.org/dist/couchdb/source/2.2.0/apache-couchdb-2.2.0.tar.gz
+        #source: https://github.com/apache/couchdb.git
 
 Review comment:
   I believe line 19 does use the tar ball; I left the git option in below; but the suggestion that I'm most intrigued by is simply apt-get install couchdb directly from your pre-package file. This would simplify (greatly) the building. Although I'd like to also mantain the option to build from git or tar ball.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services