You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/05/25 01:58:00 UTC

[GitHub] [thrift] fishy commented on pull request #2153: THRIFT-5214: Connectivity check on go's TSocket

fishy commented on pull request #2153:
URL: https://github.com/apache/thrift/pull/2153#issuecomment-633339893


   @dcelasun I did some tweak on the implementation and this version runs much better, and I think if you have time to take a look at the code, it's ready for review :)
   
   I didn't mark it as ready for review because I still want to test it in our real prod first (currently it's running in our staging server). I'll mark it as "ready for review" once I'm satisfied with the prod test result. Which should happen before end of day Tuesday in the US.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org