You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2017/07/25 00:08:15 UTC
[kudu-CR] Fix bug KUDU-2058
srisaikumarr@gmail.com has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7491
Change subject: Fix bug KUDU-2058
......................................................................
Fix bug KUDU-2058
Change-Id: Ic779aa9eb3587f79252a7dd9139d54e262a8a174
---
M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/7491/1
--
To view, visit http://gerrit.cloudera.org:8080/7491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic779aa9eb3587f79252a7dd9139d54e262a8a174
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
[kudu-CR] Fix bug KUDU-2058
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change.
Change subject: Fix bug KUDU-2058
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7491/1/java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
File java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java:
Line 90: if (r.getRole().equals(role)) {
Replica.getRole() returns a string, so this would always be false. I think you would also need to change Replica.getRole() to return the Role.
--
To view, visit http://gerrit.cloudera.org:8080/7491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic779aa9eb3587f79252a7dd9139d54e262a8a174
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Fix bug KUDU-2058
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
srisaikumarr@gmail.com has abandoned this change.
Change subject: Fix bug KUDU-2058
......................................................................
Abandoned
will add new patch.
--
To view, visit http://gerrit.cloudera.org:8080/7491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic779aa9eb3587f79252a7dd9139d54e262a8a174
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>