You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2013/11/12 14:52:18 UTC
[jira] [Commented] (LUCENE-5301) All PackedInts APIs should share a
common interface for random-access reads
[ https://issues.apache.org/jira/browse/LUCENE-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820099#comment-13820099 ]
ASF subversion and git services commented on LUCENE-5301:
---------------------------------------------------------
Commit 1541063 from [~jpountz] in branch 'dev/trunk'
[ https://svn.apache.org/r1541063 ]
LUCENE-5301: Add a common interface to PackedInts data-structures, which extends NumericDocValues.
> All PackedInts APIs should share a common interface for random-access reads
> ---------------------------------------------------------------------------
>
> Key: LUCENE-5301
> URL: https://issues.apache.org/jira/browse/LUCENE-5301
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-5301.patch, LUCENE-5301.patch
>
>
> It would be convenient if all PackedInts had a super-class with the {{long get(long index)}} method. Maybe this super-class could even be NumericDocValues so that doc values formats don't need to wrap eg. BlockPackedReader into this kind of construct:
> {code}
> final BlockPackedReader reader = new BlockPackedReader(data, entry.packedIntsVersion, entry.blockSize, entry.count, true);
> return new LongNumericDocValues() {
> @Override
> public long get(long id) {
> return reader.get(id);
> }
> };
> {code}
> Instead, they could just
> {code}
> return new BlockPackedReader(data, entry.packedIntsVersion, entry.blockSize, entry.count, true);
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org