Re: [PR] feat: job scheduling with push based job status updates [datafusion-ballista]

["danielhumanmod (via GitHub)" <gi...@apache.org>]

danielhumanmod commented on code in PR #1478:
URL: https://github.com/apache/datafusion-ballista/pull/1478#discussion_r2868218677


##########
ballista/scheduler/src/scheduler_server/grpc.rs:
##########
@@ -333,6 +343,82 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> SchedulerGrpc
         Ok(Response::new(RemoveSessionResult { success: true }))
     }
 
+    async fn execute_query_push(
+        &self,
+        request: tonic::Request<ExecuteQueryParams>,
+    ) -> std::result::Result<tonic::Response<Self::ExecuteQueryPushStream>, tonic::Status>
+    {
+        let query_params = request.into_inner();
+        if let ExecuteQueryParams {
+            query: Some(query),
+            session_id,
+            operation_id,
+            settings,
+        } = query_params
+        {
+            let job_name = settings
+                .iter()
+                .find(|s| s.key == BALLISTA_JOB_NAME)
+                .and_then(|s| s.value.clone())
+                .unwrap_or_default();
+
+            let job_id = self.state.task_manager.generate_job_id();

Review Comment:
   This `job_id` is created, logged but no further usage. In addition, `self.submit_job` (L402) will generate a `job_id` again. 
   
   We might want to use only one job_id here, maybe the one from `submit_job`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org