You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/19 12:33:09 UTC
[GitHub] [ozone] Galsza opened a new pull request, #3862: HDDS-5704. Ozone URI syntax description in help content needs to mention about ozone service id
Galsza opened a new pull request, #3862:
URL: https://github.com/apache/ozone/pull/3862
## What changes were proposed in this pull request?
Updated the URI syntax description so that it contains examples of serviceId and port usage.
## What is the link to the Apache JIRA
[Improve the description of Ozone URI in Ozone Shell help message](https://issues.apache.org/jira/browse/HDDS-5704)
## How was this patch tested?
Running on a local docker cluster I've reproduced the message and also experimented on separate ways how the URIs can be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3862: HDDS-5704. Ozone URI syntax description in help content needs to mention about ozone service id
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3862:
URL: https://github.com/apache/ozone/pull/3862#issuecomment-1303068044
> should we move this to be `ofs` as `o3` should most likely get deprecated?
This is for the `o3://` URLs for OM client, not related to OFS/O3FS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3862: HDDS-5704. Ozone URI syntax description in help content needs to mention about ozone service id
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3862:
URL: https://github.com/apache/ozone/pull/3862#discussion_r1004662944
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/Shell.java:
##########
@@ -29,11 +29,16 @@
*/
public abstract class Shell extends GenericCli {
- public static final String OZONE_URI_DESCRIPTION = "Ozone URI could start "
- + "with o3:// or without prefix. URI may contain the host/serviceId "
- + "and port of the OM server. Both are optional. "
- + "If they are not specified it will be identified from "
- + "the config files.";
+ public static final String OZONE_URI_DESCRIPTION = "Ozone URI could either " +
+ "be a full URI or short URI.\n" +
+ "Full URI should start with o3://serviceId/ " +
+ "and can optionally also contain " +
+ "the port number: o3://serviceId:9999/\n" +
+ "Example of a full URI for a key:\no3://om/vol1/bucket1/key1\n" +
+ "With port number for a volume:\no3://om:9862/vol1/\n" +
+ "Not specified information will be identified from the config files.\n" +
Review Comment:
Instead of "Not specified information" I think one of the following would be better:
* "Unspecified information"
* "Any optional part omitted"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3862: HDDS-5704. Ozone URI syntax description in help content needs to mention about ozone service id
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3862:
URL: https://github.com/apache/ozone/pull/3862#issuecomment-1303052147
@adoroszlai should we move this to be `ofs` as `o3` should most likely get deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Galsza commented on a diff in pull request #3862: HDDS-5704. Ozone URI syntax description in help content needs to mention about ozone service id
Posted by GitBox <gi...@apache.org>.
Galsza commented on code in PR #3862:
URL: https://github.com/apache/ozone/pull/3862#discussion_r1011911306
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/Shell.java:
##########
@@ -29,11 +29,16 @@
*/
public abstract class Shell extends GenericCli {
- public static final String OZONE_URI_DESCRIPTION = "Ozone URI could start "
- + "with o3:// or without prefix. URI may contain the host/serviceId "
- + "and port of the OM server. Both are optional. "
- + "If they are not specified it will be identified from "
- + "the config files.";
+ public static final String OZONE_URI_DESCRIPTION = "Ozone URI could either " +
+ "be a full URI or short URI.\n" +
+ "Full URI should start with o3://serviceId/ " +
+ "and can optionally also contain " +
+ "the port number: o3://serviceId:9999/\n" +
+ "Example of a full URI for a key:\no3://om/vol1/bucket1/key1\n" +
+ "With port number for a volume:\no3://om:9862/vol1/\n" +
+ "Not specified information will be identified from the config files.\n" +
Review Comment:
Thank you for the review, fixed both issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3862: HDDS-5704. Ozone URI syntax description in help content needs to mention about ozone service id
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3862:
URL: https://github.com/apache/ozone/pull/3862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org