You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/07/30 10:54:56 UTC

[GitHub] [guacamole-client] necouchman commented on a change in pull request #556: GUACAMOLE-1147: Add ldap-member-attribute-type support for Docker

necouchman commented on a change in pull request #556:
URL: https://github.com/apache/guacamole-client/pull/556#discussion_r462376299



##########
File path: guacamole-docker/bin/start.sh
##########
@@ -438,6 +438,7 @@ END
     set_optional_property "ldap-user-search-filter" "$LDAP_USER_SEARCH_FILTER"
     set_optional_property "ldap-config-base-dn"     "$LDAP_CONFIG_BASE_DN"
     set_optional_property "ldap-group-base-dn"      "$LDAP_GROUP_BASE_DN"
+    set_optional_property "ldap-member-attribute-type"   "$LDAP_MEMBER_ATTRIBUTE_TYPE"

Review comment:
       Probably makes sense to line up the spacing on these lines so that the final column all starts in the same place.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org