[GitHub] [druid] suneet-s commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length
URL: https://github.com/apache/druid/pull/9356#discussion_r380834869
 
 

 ##########
 File path: extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureDataSegmentConfig.java
 ##########
 @@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.storage.azure;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+
+import javax.annotation.Nonnull;
+import javax.validation.constraints.Min;
+import javax.validation.constraints.NotNull;
+
+/**
+ * Stores the configuration for segments written to Azure deep storage
+ */
+public class AzureDataSegmentConfig
+{
+  @JsonProperty
+  @NotNull
+  private String container;
+
+  @JsonProperty
+  @Nonnull
 
 Review comment:
   Why `Nonnull` when the previous one is annotated with 'NotNull'?
   
   Also is prefix a required config? Why is assigned to an empty string?
   
   Perhaps using a `@JsonCreator` constructor with Precondition checks will make it clearer what is required in each field
   
   ```
    @JsonCreator
     public AzureDataSegmentConfig(
         ...
         @JsonProperty("prefix") String prefix)
     {
       this.prefix = Preconditions.checkState(!StringUtils.isEmpty(prefix), "prefix must be non empty");
       ...
     }
   ```
   
   Then you don't need all the setters

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org