You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "fuyou001 (via GitHub)" <gi...@apache.org> on 2026/08/06 02:54:15 UTC
[PR] [ISSUE #10819] Correct misleading CommitLog buffer comment [rocketmq]
fuyou001 opened a new pull request, #10820:
URL: https://github.com/apache/rocketmq/pull/10820
### Which Issue(s) This PR Fixes
- Fixes #10819
### Brief Description
Correct the misleading comment before `byteBuffer.put(preEncodeBuffer)` in `DefaultAppendMessageCallback#doAppend(...)`.
The destination buffer belongs to the CommitLog append path and may be backed by the mapped byte buffer, the transient write buffer, or the shared staging buffer used by `writeWithoutMmap`. It is not a queue or ConsumeQueue buffer. The revised comment also makes clear that this line copies an already encoded message.
This is a documentation-only change with no runtime behavior, API, protocol, configuration, or persisted-format impact.
### How Did You Test This Change?
- Ran `git diff --check` successfully.
- No behavioral tests were added or run because only a source-code comment changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #10819] Correct misleading CommitLog buffer comment [rocketmq]
Posted by "ShannonDing (via GitHub)" <gi...@apache.org>.
ShannonDing merged PR #10820:
URL: https://github.com/apache/rocketmq/pull/10820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #10819] Correct misleading CommitLog buffer comment [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10820:
URL: https://github.com/apache/rocketmq/pull/10820#issuecomment-5200058770
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10820?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.25%. Comparing base ([`2daf0e2`](https://app.codecov.io/gh/apache/rocketmq/commit/2daf0e2ca91a1592d18235d43e5d709d1c35d15f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0724d74`](https://app.codecov.io/gh/apache/rocketmq/commit/0724d74128a9990696324ae8f817f07f4e52be00?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #10820 +/- ##
=============================================
- Coverage 48.32% 48.25% -0.08%
+ Complexity 13516 13497 -19
=============================================
Files 1380 1380
Lines 101138 101138
Branches 13120 13120
=============================================
- Hits 48876 48800 -76
- Misses 46298 46353 +55
- Partials 5964 5985 +21
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/10820?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org