You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2018/12/07 18:27:44 UTC

[GitHub] jadams-tresys commented on a change in pull request #143: Support dfdl:length="prefixed"

jadams-tresys commented on a change in pull request #143: Support dfdl:length="prefixed"
URL: https://github.com/apache/incubator-daffodil/pull/143#discussion_r239901970
 
 

 ##########
 File path: daffodil-propgen/src/main/scala/org/apache/daffodil/propGen/PropertyGenerator.scala
 ##########
 @@ -493,9 +493,18 @@ object Currency {
   }
 
   def generateNonEnumInstantiation(propName: String, typeName: String) = {
-    val midTemplate = """  def EUR = convertToTYPE(cacheProperty("EUR").value)
-"""
     val converterName = getConverterTypeName(typeName)
+    val midTemplate = if (converterName != "QName") {
 
 Review comment:
   Just for my own sanity, these QName changes don't have anything to do with the prefixed length stuff, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services