You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Justin Mclean <ju...@classsoftware.com> on 2013/04/28 05:29:40 UTC
Re: git commit: [flex-sdk] - FLEX-33526: Added the findRowIndices
method to allow array values.
Looks like it might RTE if values array is null?
Re: git commit: [flex-sdk] - FLEX-33526: Added the findRowIndices
method to allow array values.
Posted by Alex Harui <ah...@adobe.com>.
If it isn't in the coding standards doc, I think we don't use "== null"
unless you have to (Strings, and Objects that can be a String).
On 4/28/13 6:58 AM, "Justin Mclean" <ju...@classsoftware.com> wrote:
> Hi,
>
>> Sounds reasonable to me. I try to be consistent with it.
> What does the SDK generally do? It's best to try and stay in line with it
> (slightly inconsistent) style. Thinks like this should probably be written up
> somewhere :-)
>
> Justin
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: git commit: [flex-sdk] - FLEX-33526: Added the findRowIndices method to allow array values.
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Sounds reasonable to me. I try to be consistent with it.
What does the SDK generally do? It's best to try and stay in line with it (slightly inconsistent) style. Thinks like this should probably be written up somewhere :-)
Justin
Re: git commit: [flex-sdk] - FLEX-33526: Added the findRowIndices
method to allow array values.
Posted by Mark Kessler <ke...@gmail.com>.
Sounds reasonable to me. I try to be consistent with it. But I usually
use (displayobject) (!displayobject) to test existence of the visible
objects and I use (variable ==null) for the rest.
Anywho tiny update for the consistency.
On Sun, Apr 28, 2013 at 8:41 AM, Justin Mclean <ju...@classsoftware.com>wrote:
> Hi,
>
> > You were right. I've updated it to test for them. Seems to be good now.
>
> Not a biggie but try be be consistent with the null checks ie
> dataProvider vs values != null.
>
> Also nothing wrong with doing something like this at the top of the
> function.
>
> if (dataProvider == null || values == null)
> return [];
>
> Thanks,
> Justin
>
>
>
Re: git commit: [flex-sdk] - FLEX-33526: Added the findRowIndices method to allow array values.
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> You were right. I've updated it to test for them. Seems to be good now.
Not a biggie but try be be consistent with the null checks ie dataProvider vs values != null.
Also nothing wrong with doing something like this at the top of the function.
if (dataProvider == null || values == null)
return [];
Thanks,
Justin
Re: git commit: [flex-sdk] - FLEX-33526: Added the findRowIndices
method to allow array values.
Posted by Mark Kessler <ke...@gmail.com>.
You were right. I've updated it to test for them. Seems to be good now.
Thanks Justin.
On Sat, Apr 27, 2013 at 11:29 PM, Justin Mclean <ju...@classsoftware.com>wrote:
> Looks like it might RTE if values array is null?
>
Re: git commit: [flex-sdk] - FLEX-33526: Added the findRowIndices
method to allow array values.
Posted by Mark Kessler <ke...@gmail.com>.
I'll take a look.
On Sat, Apr 27, 2013 at 11:29 PM, Justin Mclean <ju...@classsoftware.com>wrote:
> Looks like it might RTE if values array is null?
>