You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/08/18 10:06:46 UTC

[GitHub] [flink] godfreyhe commented on a diff in pull request #20612: [FLINK-28995][hive] HiveSourceDynamicFileEnumerator filters out a partition without matching if one of the fields is null but its type is not nullable.

godfreyhe commented on code in PR #20612:
URL: https://github.com/apache/flink/pull/20612#discussion_r948936211


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceDynamicFileEnumerator.java:
##########
@@ -159,6 +161,9 @@ RowData createRowData(RowType rowType, Map<String, String> partitionSpec) {
                     throw new UnsupportedOperationException(
                             "Unsupported type for dynamic filtering:" + rowType.getTypeAt(i));
             }
+            if (!fieldType.isNullable() && convertedValue == null) {

Review Comment:
   What if the field type is nullable ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org