You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/04/30 10:13:18 UTC
[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #5749: [Bug-fix] Pause routine load when data size exceeds quota
EmmyMiao87 opened a new pull request #5749:
URL: https://github.com/apache/incubator-doris/pull/5749
## Proposed changes
In the previous code, the routine load task did not catch the exception of opening the transaction.
As a result, although the task cannot be executed,
no exceptions can be seen during show routine load, only the routine load job is stuck.
The PR catch the QuotaExceedException when opening a transaction.
If the routine load task cannot be executed due to the exhaustion of the quota,
the routine load will be paused and an error message will be presented to the user.
Similarly, other load method will also catch similar exceptions and cancel job.
Fixed #5745
x
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #5745 ) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #5749: [Bug-fix] Pause routine load when data size exceeds quota
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #5749:
URL: https://github.com/apache/incubator-doris/pull/5749#discussion_r627057338
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/MetaNotFoundException.java
##########
@@ -17,12 +17,14 @@
package org.apache.doris.common;
+import static org.apache.doris.common.InternalErrorCode.META_NOT_FOUND_ERR;
Review comment:
Just to follow the existing code style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #5749: [Bug-fix] Pause routine load when data size exceeds quota
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #5749:
URL: https://github.com/apache/incubator-doris/pull/5749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #5749: [Bug-fix] Pause routine load when data size exceeds quota
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #5749:
URL: https://github.com/apache/incubator-doris/pull/5749#discussion_r627036792
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/MetaNotFoundException.java
##########
@@ -17,12 +17,14 @@
package org.apache.doris.common;
+import static org.apache.doris.common.InternalErrorCode.META_NOT_FOUND_ERR;
Review comment:
Changed, but why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #5749: [Bug-fix] Pause routine load when data size exceeds quota
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #5749:
URL: https://github.com/apache/incubator-doris/pull/5749#discussion_r623893536
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/MetaNotFoundException.java
##########
@@ -17,12 +17,14 @@
package org.apache.doris.common;
+import static org.apache.doris.common.InternalErrorCode.META_NOT_FOUND_ERR;
Review comment:
Do not use static import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org