You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/06 12:19:07 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #33916: [SPARK-36667][SS] Close resources properly in StateStoreSuite/RocksDBStateStoreSuite

HyukjinKwon commented on a change in pull request #33916:
URL: https://github.com/apache/spark/pull/33916#discussion_r702857223



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala
##########
@@ -1122,6 +1157,14 @@ abstract class StateStoreSuiteBase[ProviderClass <: StateStoreProvider]
     }
   }
 
+  protected def tryWithProviderResource[T](provider: ProviderClass)(f: ProviderClass => T): T = {

Review comment:
       qq: can we use `Utils.tryWithResource` instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org