You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "iryoung jeong (JIRA)" <ji...@apache.org> on 2010/10/04 08:05:32 UTC
[jira] Created: (CASSANDRA-1570) sort is not necessary for
getMaxEndpointStateVersion() in Gossiper
sort is not necessary for getMaxEndpointStateVersion() in Gossiper
------------------------------------------------------------------
Key: CASSANDRA-1570
URL: https://issues.apache.org/jira/browse/CASSANDRA-1570
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: iryoung jeong
Priority: Minor
hello,
while I reviewing the cassandra source code, I think, there's redundant sort in getMaxEndpointStateVersion() in Gossiper.
To get a max value, sorting is not necessary.. isn't it?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1570) sort is not necessary for
getMaxEndpointStateVersion() in Gossiper
Posted by "iryoung jeong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
iryoung jeong updated CASSANDRA-1570:
-------------------------------------
Attachment: trunk-1570-1.txt
trunk-1570-2.txt
patch trunk-1570-1.txt remove sort & patch trunk-1570-2.txt makes method simpler.
The first one is good for future features(eg, there may be new soureces for epVersion) and the second one is just simple code that works.
I hope reviewer may choose better one. ( IMO, trunk-1570-2.txt is better.)
> sort is not necessary for getMaxEndpointStateVersion() in Gossiper
> ------------------------------------------------------------------
>
> Key: CASSANDRA-1570
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1570
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: iryoung jeong
> Priority: Minor
> Attachments: trunk-1570-1.txt, trunk-1570-2.txt
>
>
> hello,
> while I reviewing the cassandra source code, I think, there's redundant sort in getMaxEndpointStateVersion() in Gossiper.
> To get a max value, sorting is not necessary.. isn't it?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1570) sort is not necessary for
getMaxEndpointStateVersion() in Gossiper
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917972#action_12917972 ]
Hudson commented on CASSANDRA-1570:
-----------------------------------
Integrated in Cassandra #556 (See [https://hudson.apache.org/hudson/job/Cassandra/556/])
r/m unnecessary sort from Gossiper.getMaxEndpointStateVersion. patch by iryoung jeong; reviewed by jbellis for CASSANDRA-1570
> sort is not necessary for getMaxEndpointStateVersion() in Gossiper
> ------------------------------------------------------------------
>
> Key: CASSANDRA-1570
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1570
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: iryoung jeong
> Assignee: iryoung jeong
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: trunk-1570-1.txt, trunk-1570-2.txt
>
>
> hello,
> while I reviewing the cassandra source code, I think, there's redundant sort in getMaxEndpointStateVersion() in Gossiper.
> To get a max value, sorting is not necessary.. isn't it?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.