You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2014/12/22 13:48:49 UTC
Review Request 29306: [FALCON-962] Fortify ListFeedInstancesTest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29306/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-962
https://issues.apache.org/jira/browse/FALCON-962
Repository: falcon-git
Description
-------
Improvement to test stability
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java 9a822ee
Diff: https://reviews.apache.org/r/29306/diff/
Testing
-------
tested
Thanks,
Paul Isaychuk
Re: Review Request 29306: [FALCON-962] Fortify ListFeedInstancesTest
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29306/#review65776
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
<https://reviews.apache.org/r/29306/#comment109031>
use Assert.fail()
- Ruslan Ostafiychuk
On Dec. 22, 2014, 12:48 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29306/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2014, 12:48 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-962
> https://issues.apache.org/jira/browse/FALCON-962
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Improvement to test stability
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java 9a822ee
>
> Diff: https://reviews.apache.org/r/29306/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 29306: [FALCON-962] Fortify ListFeedInstancesTest
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29306/#review66024
-----------------------------------------------------------
Ship it!
Ship It!
- Ruslan Ostafiychuk
On Dec. 23, 2014, 6:36 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29306/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 6:36 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-962
> https://issues.apache.org/jira/browse/FALCON-962
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Improvement to test stability
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java 9a822ee
>
> Diff: https://reviews.apache.org/r/29306/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 29306: [FALCON-962] Fortify ListFeedInstancesTest
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29306/
-----------------------------------------------------------
(Updated Dec. 23, 2014, 6:36 p.m.)
Review request for Falcon.
Bugs: FALCON-962
https://issues.apache.org/jira/browse/FALCON-962
Repository: falcon-git
Description
-------
Improvement to test stability
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java 9a822ee
Diff: https://reviews.apache.org/r/29306/diff/
Testing
-------
tested
Thanks,
Paul Isaychuk
Re: Review Request 29306: [FALCON-962] Fortify ListFeedInstancesTest
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29306/
-----------------------------------------------------------
(Updated Dec. 23, 2014, 5:52 p.m.)
Review request for Falcon.
Bugs: FALCON-962
https://issues.apache.org/jira/browse/FALCON-962
Repository: falcon-git
Description
-------
Improvement to test stability
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java 9a822ee
Diff: https://reviews.apache.org/r/29306/diff/
Testing
-------
tested
Thanks,
Paul Isaychuk
Re: Review Request 29306: [FALCON-962] Fortify ListFeedInstancesTest
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29306/#review65911
-----------------------------------------------------------
Ship it!
Ship It!
- Ruslan Ostafiychuk
On Dec. 23, 2014, 9:43 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29306/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 9:43 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-962
> https://issues.apache.org/jira/browse/FALCON-962
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Improvement to test stability
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java 9a822ee
>
> Diff: https://reviews.apache.org/r/29306/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 29306: [FALCON-962] Fortify ListFeedInstancesTest
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29306/#review65913
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
<https://reviews.apache.org/r/29306/#comment109186>
unused import
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
<https://reviews.apache.org/r/29306/#comment109187>
feedName hides a field
- Ruslan Ostafiychuk
On Dec. 23, 2014, 9:43 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29306/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 9:43 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-962
> https://issues.apache.org/jira/browse/FALCON-962
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Improvement to test stability
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java 9a822ee
>
> Diff: https://reviews.apache.org/r/29306/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 29306: [FALCON-962] Fortify ListFeedInstancesTest
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29306/
-----------------------------------------------------------
(Updated Dec. 23, 2014, 9:43 a.m.)
Review request for Falcon.
Bugs: FALCON-962
https://issues.apache.org/jira/browse/FALCON-962
Repository: falcon-git
Description
-------
Improvement to test stability
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java 9a822ee
Diff: https://reviews.apache.org/r/29306/diff/
Testing
-------
tested
Thanks,
Paul Isaychuk
Re: Review Request 29306: [FALCON-962] Fortify ListFeedInstancesTest
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29306/
-----------------------------------------------------------
(Updated Dec. 23, 2014, 9:42 a.m.)
Review request for Falcon.
Bugs: FALCON-962
https://issues.apache.org/jira/browse/FALCON-962
Repository: falcon-git
Description
-------
Improvement to test stability
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java 9a822ee
Diff: https://reviews.apache.org/r/29306/diff/
Testing
-------
tested
Thanks,
Paul Isaychuk
Re: Review Request 29306: [FALCON-962] Fortify ListFeedInstancesTest
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29306/
-----------------------------------------------------------
(Updated Dec. 23, 2014, 9:12 a.m.)
Review request for Falcon.
Changes
-------
addressing comment
Bugs: FALCON-962
https://issues.apache.org/jira/browse/FALCON-962
Repository: falcon-git
Description
-------
Improvement to test stability
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java 9a822ee
Diff: https://reviews.apache.org/r/29306/diff/
Testing
-------
tested
Thanks,
Paul Isaychuk