You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by Greg Brown <gk...@mac.com> on 2010/09/25 15:27:04 UTC
PIVOT-534
Hey Chris,
Just noticed a couple of minor things that we should probably change with respect to PIVOT-534:
- The transition values are no longer static final, so they should be moved up above the constant declarations. In fact, since they are styles, they should immediately follow all of the other style properties (both the fields as well as the getter/setter methods - we try to mimic the order so the methods are easier to locate).
- We should probably define constants that contain the default values, and use those to initialize the variables.
BTW, I am currently using the new "debugfocus" property to help resolve PIVOT-646 and it is working great. :-)
G
Re: PIVOT-534
Posted by Chris Bartlett <cb...@gmail.com>.
I made the changes and hopefully got the ordering correct.
(r1002616)
Chris
On 25 September 2010 21:16, Greg Brown <gk...@mac.com> wrote:
> In general, we follow this organization:
>
> Static inner classes
> Inner classes (but this order is a bit flexible)
> Instance fields
> Static fields
> Constructors
> Instance methods
> Static methods
>
> Generally, we try to put public members first, and protected/private
> members tend to be interspersed throughout. I generally try to group
> protected and private methods with the public methods that use them; if they
> are used by a lot of methods, I'll usually put them at the bottom of the
> class.
>
>
> On Sep 25, 2010, at 9:59 AM, Chris Bartlett wrote:
>
> > No problem, I will sort it out.
> >
> > What is the Pivot class source structure/ordering scheme? I haven't seen
> it
> > documented anywhere, but admittedly didn't look too hard.
> >
> > Chris
> >
> > On 25 September 2010 20:27, Greg Brown <gk...@mac.com> wrote:
> >
> >> Hey Chris,
> >>
> >> Just noticed a couple of minor things that we should probably change
> with
> >> respect to PIVOT-534:
> >>
> >> - The transition values are no longer static final, so they should be
> moved
> >> up above the constant declarations. In fact, since they are styles, they
> >> should immediately follow all of the other style properties (both the
> fields
> >> as well as the getter/setter methods - we try to mimic the order so the
> >> methods are easier to locate).
> >>
> >> - We should probably define constants that contain the default values,
> and
> >> use those to initialize the variables.
> >>
> >> BTW, I am currently using the new "debugfocus" property to help resolve
> >> PIVOT-646 and it is working great. :-)
> >>
> >> G
> >>
> >>
>
>
Re: PIVOT-534
Posted by Greg Brown <gk...@mac.com>.
In general, we follow this organization:
Static inner classes
Inner classes (but this order is a bit flexible)
Instance fields
Static fields
Constructors
Instance methods
Static methods
Generally, we try to put public members first, and protected/private members tend to be interspersed throughout. I generally try to group protected and private methods with the public methods that use them; if they are used by a lot of methods, I'll usually put them at the bottom of the class.
On Sep 25, 2010, at 9:59 AM, Chris Bartlett wrote:
> No problem, I will sort it out.
>
> What is the Pivot class source structure/ordering scheme? I haven't seen it
> documented anywhere, but admittedly didn't look too hard.
>
> Chris
>
> On 25 September 2010 20:27, Greg Brown <gk...@mac.com> wrote:
>
>> Hey Chris,
>>
>> Just noticed a couple of minor things that we should probably change with
>> respect to PIVOT-534:
>>
>> - The transition values are no longer static final, so they should be moved
>> up above the constant declarations. In fact, since they are styles, they
>> should immediately follow all of the other style properties (both the fields
>> as well as the getter/setter methods - we try to mimic the order so the
>> methods are easier to locate).
>>
>> - We should probably define constants that contain the default values, and
>> use those to initialize the variables.
>>
>> BTW, I am currently using the new "debugfocus" property to help resolve
>> PIVOT-646 and it is working great. :-)
>>
>> G
>>
>>
Re: PIVOT-534
Posted by Chris Bartlett <cb...@gmail.com>.
No problem, I will sort it out.
What is the Pivot class source structure/ordering scheme? I haven't seen it
documented anywhere, but admittedly didn't look too hard.
Chris
On 25 September 2010 20:27, Greg Brown <gk...@mac.com> wrote:
> Hey Chris,
>
> Just noticed a couple of minor things that we should probably change with
> respect to PIVOT-534:
>
> - The transition values are no longer static final, so they should be moved
> up above the constant declarations. In fact, since they are styles, they
> should immediately follow all of the other style properties (both the fields
> as well as the getter/setter methods - we try to mimic the order so the
> methods are easier to locate).
>
> - We should probably define constants that contain the default values, and
> use those to initialize the variables.
>
> BTW, I am currently using the new "debugfocus" property to help resolve
> PIVOT-646 and it is working great. :-)
>
> G
>
>